This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 3: There are 3 Puncturing values, namely PS1,PS2,PS3. These are valid only for EGPRS case. Punct[0] corresponds to 1st EGPRS RLC block, Punct[1] corresponds to 2nd EGPRS RLC block. In case of EGPRS header type 2 and 3, only Punct[0] valid. Punct[1] along with Punct[0] is valid only for the case of HeaderType 1. For GPRS case, Punct[0] and Punct[1] shall be initialized to INVALID and EGPRS(type 2,type 3) case Punct[1] shall be initialized to INVALID. For me, Any value other than specification defined is invalid. Hence EGPRS_PS_INVALID is set to 3. >gprs_rlc_mcs_cps(), where the puncturing values are passed into, does not check >against *_INVALID items, but simply uses them. So now I'm sure that this patch >is not "the real" fix. I would suggest not to jump into verdict before having proper analysis of code. With the explanation as reference above, please have a close look into gprs_rlc_mcs_cps function. You would realize initializing the "punct" to INVALID is a proper fix. However I agree that, We need to memset the both indexes of "punct" to EGPRS_PS_INVALID as suggested by you. Let me know if you have any queries. -- To view, visit https://gerrit.osmocom.org/1411 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice54edc7e4a936eb2f2dd8a243673a30dceef542 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: No