This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/1433/1/src/fsm.c
File src/fsm.c:
Line 460: #define ENUM_VAL_TO_VALUE_STRING(X) { X, #X }
> I think I use a similar one in gtphub somewhere, IIRC... do other reviewers
Yes, please let's add that.
Line 471: const char *osmo_fsm_term_cause_name(enum osmo_fsm_term_cause cause)
> I remember it so that we agreed to provide the value strings array publicly
Yes, an inline wrapper function should be the way to go. Gives us best of both worlds. We should keep old non-inline functions. Or is there any advantage of a "real" function that I miss out?
--
To view, visit https://gerrit.osmocom.org/1433
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf63d3cadb0d46bf454e3314ebb439240cafd834
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes