libosmocore[master]: add value strings for enum osmo_fsm_term_cause and use for l...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Dec 14 17:51:18 UTC 2016


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/1433/1/src/fsm.c
File src/fsm.c:

Line 460: #define ENUM_VAL_TO_VALUE_STRING(X) { X, #X }
This seems like generally useful macro. Perhaps move to utils?


Line 471: const char *osmo_fsm_term_cause_name(enum osmo_fsm_term_cause cause)
I thought the consensus was to use get_value_string directly instead of introducing more 1-line functions.


-- 
To view, visit https://gerrit.osmocom.org/1433
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf63d3cadb0d46bf454e3314ebb439240cafd834
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list