[MERGED] openbsc[master]: move gprs/oap.c to libcommon/oap_client.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Dec 13 14:54:04 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: move gprs/oap.c to libcommon/oap_client.c
......................................................................


move gprs/oap.c to libcommon/oap_client.c

This is in preparation for libvlr.

Related: OS#1592
Change-Id: Ib526df6d9de55a1e59a379d5e2c8541ed0ef67e3
---
M openbsc/src/gprs/Makefile.am
M openbsc/src/libcommon/Makefile.am
R openbsc/src/libcommon/oap_client.c
M openbsc/tests/oap/Makefile.am
M openbsc/tests/sgsn/Makefile.am
5 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/gprs/Makefile.am b/openbsc/src/gprs/Makefile.am
index ab2517e..d059aee 100644
--- a/openbsc/src/gprs/Makefile.am
+++ b/openbsc/src/gprs/Makefile.am
@@ -92,7 +92,6 @@
 	sgsn_cdr.c \
 	sgsn_ares.c \
 	slhc.c \
-	oap.c \
 	gprs_llc_xid.c \
 	v42bis.c \
 	$(NULL)
@@ -137,9 +136,9 @@
 gsup_test_client_SOURCES = \
 	gprs_gsup_client.c \
 	gsup_test_client.c \
-	oap.c \
 	$(NULL)
 gsup_test_client_LDADD = \
+	$(top_builddir)/src/libcommon/libcommon.a \
 	$(LIBOSMOCORE_LIBS) \
 	$(LIBOSMOGSM_LIBS) \
 	$(LIBOSMOVTY_LIBS) \
diff --git a/openbsc/src/libcommon/Makefile.am b/openbsc/src/libcommon/Makefile.am
index 6cfebc2..6582d1e 100644
--- a/openbsc/src/libcommon/Makefile.am
+++ b/openbsc/src/libcommon/Makefile.am
@@ -23,6 +23,7 @@
 	debug.c \
 	gsm_data.c \
 	gsm_data_shared.c \
+	oap_client.c \
 	socket.c \
 	talloc_ctx.c \
 	gsm_subscriber_base.c \
diff --git a/openbsc/src/gprs/oap.c b/openbsc/src/libcommon/oap_client.c
similarity index 100%
rename from openbsc/src/gprs/oap.c
rename to openbsc/src/libcommon/oap_client.c
diff --git a/openbsc/tests/oap/Makefile.am b/openbsc/tests/oap/Makefile.am
index bb9ebb2..c17abb5 100644
--- a/openbsc/tests/oap/Makefile.am
+++ b/openbsc/tests/oap/Makefile.am
@@ -27,7 +27,6 @@
 	$(NULL)
 
 oap_test_LDADD = \
-	$(top_builddir)/src/gprs/oap.o \
 	$(top_builddir)/src/gprs/gprs_utils.o \
 	$(top_builddir)/src/libcommon/libcommon.a \
 	$(LIBOSMOCORE_LIBS) \
diff --git a/openbsc/tests/sgsn/Makefile.am b/openbsc/tests/sgsn/Makefile.am
index 9e1a5a8..00b80f6 100644
--- a/openbsc/tests/sgsn/Makefile.am
+++ b/openbsc/tests/sgsn/Makefile.am
@@ -54,7 +54,6 @@
 	$(top_builddir)/src/gprs/gprs_utils.o \
 	$(top_builddir)/src/gprs/gprs_subscriber.o \
 	$(top_builddir)/src/gprs/gprs_gb_parse.o \
-	$(top_builddir)/src/gprs/oap.o \
         $(top_builddir)/src/gprs/gprs_llc_xid.o \
 	$(top_builddir)/src/gprs/gprs_sndcp_xid.o \
         $(top_builddir)/src/gprs/slhc.o \

-- 
To view, visit https://gerrit.osmocom.org/1389
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib526df6d9de55a1e59a379d5e2c8541ed0ef67e3
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list