This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: (2 comments) yea, now that we've got the discussion going on PS3, it's hard to jump to the latest patch set. But I wish we'd be through discussing this one anyway :) https://gerrit.osmocom.org/#/c/1265/3/openbsc/contrib/ipa.py File openbsc/contrib/ipa.py: Line 27: class IPA(object): > This isn't a function, it's class. See Harald's comment above. I know. The point is that even libosmocore doesn't always use all-caps everywhere, but whatever capitalization matches the situation. All I'm saying is that here, I'd prefer "Ipa" to indicate a class name. Many hackers do keep acronym class names in all-caps, but IMHO it then looks like a string constant or the like. Anyway, we've talked about this minor issue way too much already... Line 113: return self.__tag(self.IDTAG['SERNR'], data) > So you suggest to use In one central place, define SERNR = 'SERNR' and make sure that all callers everywhere use only the string constant. That's how to prevent typo mistakes. Does this not make sense here? -- To view, visit https://gerrit.osmocom.org/1265 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e37ec143183e422c0b31af95d183bd84f0c328 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes