This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 9: Code-Review+2 (2 comments) again leaving it up to you... https://gerrit.osmocom.org/#/c/1266/9/openbsc/contrib/bsc_control.py File openbsc/contrib/bsc_control.py: Line 20: def do_set_get(sck, var, value = None): Now I notice that I don't understand the return values of do_set_get(), maybe a short doc would be good. Line 90: (a, _, _) = do_set_get(sock, args[0]) ah, so this is actually a "get", at first I misread as a "set". Maybe get_var() above could also return the answer, instead of the 'v'? Then this would explicitly be "get_var(...)", no misunderstanding possible... -- To view, visit https://gerrit.osmocom.org/1266 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25fd7cd4b42126354b72abd60a3837be5d13e159 Gerrit-PatchSet: 9 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes