This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 10:
(2 comments)
https://gerrit.osmocom.org/#/c/1268/10/openbsc/contrib/twisted_ipa.py
File openbsc/contrib/twisted_ipa.py:
Line 46: """
> How can I make it more helpful?
It's the typical JavaDoc syndrome:
/** Crank the lever */
public int crankLever(){ }
The comment exactly reflects the function name.
In those cases I would simply drop the comment entirely.
Line 104: pass
> Well, yes - if you use wrong handler for the messages than result would be
reservation: I haven't yet understood what this class' use is. So far it looks to me like it is designed to do only debug logging?
If it or its subclasses are supposed to also take action, I would expect to throw an exception or log an error if an unimplemented section is invoked.
--
To view, visit https://gerrit.osmocom.org/1268
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07559df420b7fe8418f3412f45acd9a375e43bc5
Gerrit-PatchSet: 10
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes