This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 8: (2 comments) Pierre is right https://gerrit.osmocom.org/#/c/1046/8/src/osmo-bts-trx/l1_if.c File src/osmo-bts-trx/l1_if.c: Line 155: return trx_sched_set_lchan(&l1h->l1s, lchan->nr, LID_DEDIC, 0); chan_nr is the RSL Channel Number IE value, a bitfield aggregation of lchan type bits (cbits) and lchan number (lowest three bits) which is expected to differ from our plain lchan->nr channel number. @Pierre, you're right that indeed the patch's line 155 is wrong: it passes lchan->nr instead of originally chan_nr. Unfortunately the chan_nr field "can't" be passed into the scope and would need to be re-calculated, or trx_sched_set_lchan() needs to be refactored? I'll see whether we can fix quickly or revert. Line 162: return trx_sched_set_lchan(&l1h->l1s, lchan->nr, LID_SACCH, 0); same here -- To view, visit https://gerrit.osmocom.org/1046 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0d3b19dbfaa16d1734321a07a6eb0355bfd77c9 Gerrit-PatchSet: 8 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pierre.baudry <pierre.baudry at diateam.net> Gerrit-HasComments: Yes