This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 8: Code-Review+2 (3 comments) if you like, fix the cosmetics and bump me on IM to renew the +2; but not that important either. Disclaimer: I don't understand in depth what this patch does, but looks good according to the function names. Also this has been up for review for long enough now, time to unblock. https://gerrit.osmocom.org/#/c/1266/8/openbsc/contrib/bsc_control.py File openbsc/contrib/bsc_control.py: Line 27: do_set_get(sck, var, val) from below: a, _, _ = do_set_get(... return a (and yes, you don't need to put braces around 'a, _, _') Line 70: (a, _, _) = do_set_get(sock, args[0], ' '.join(args[1:])) looks like set_var() should include this to return the set val, and use set_var() here? Line 77: print "Got message:", a because it is reused -- To view, visit https://gerrit.osmocom.org/1266 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25fd7cd4b42126354b72abd60a3837be5d13e159 Gerrit-PatchSet: 8 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes