[MERGED] openbsc[master]: bsc_ctrl: Ensure we don't pass NULL string into strtok_r()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 9 15:35:32 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: bsc_ctrl: Ensure we don't pass NULL string into strtok_r()
......................................................................


bsc_ctrl: Ensure we don't pass NULL string into strtok_r()

Change-Id: I03bea132377c0136b55b6fdad99a5d92da12e692
Fixes: Coverity CID 135180
---
M openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c b/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
index f10a74a..5352bf2 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
@@ -605,6 +605,7 @@
 	char *saveptr = NULL;
 	char *inp, *cic, *alert, *text;
 
+	OSMO_ASSERT(cmd);
 	inp = talloc_strdup(cmd, value);
 
 	cic = strtok_r(inp, ",", &saveptr);

-- 
To view, visit https://gerrit.osmocom.org/1323
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03bea132377c0136b55b6fdad99a5d92da12e692
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list