This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/1398/1/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:
Line 2123: RlcMacUplink_t ul_control_block;
= { 0, }; could work above as well.
PS1, Line 2127: _
I would prefer to use sizeof(ul_control_block) to protect against changes of the type.
--
To view, visit https://gerrit.osmocom.org/1398
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6993fd6f89c9d9ed00ec6cb4b27953e72fa1f52
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes