libosmocore[master]: Implement GSMTAP log target

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 8 16:27:44 UTC 2016


Patch Set 2:

> I don't think we really have to support all the same types sprintf
 > does: 1,2,4,8 byte integers and strings will cover 99% of the
 > use-cases. Those could be sent as TV and TLV and fed to sprintf in
 > wireshark. Shall I make a ticket for that?

YEs, please create a ticket. The problem is not the wire encoding, but the fact that you have to traverse the format-string to detect %s and the like.  And that is part of the expensive operation that you'd want to avoid in the first place, right?  Or are you sure __typeof() trickery is sufficient? for arbitrary argument lists/ordering?

-- 
To view, visit https://gerrit.osmocom.org/1357
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a7e72b8c9c6f6f2d76d1ea2332dcdee12394625
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list