libosmocore[master]: Implement GSMTAP log target

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Dec 5 18:50:11 UTC 2016


Patch Set 2: Code-Review+2

> Just for the record, as discussed today: would be much faster to
 > send raw string with formatters and data and let wireshark do
 > string formatting. Although this might open up can of worms with
 > string format vulnerabilities.

yes, but that's not an either-or, but a another variant of a future different GSMTAP sub-type of the logging.  The difficulty is to know about the type of the function arguments and encoding them in the GSMTAP message while not paying the same cost as the sprintf format string traversal.

-- 
To view, visit https://gerrit.osmocom.org/1357
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a7e72b8c9c6f6f2d76d1ea2332dcdee12394625
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list