libosmocore[master]: gsm0480.c: code dup: have common msgb alloc functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Dec 2 17:17:39 UTC 2016


Patch Set 3:

> I'm not quite sure if it is a good idea to hard-code message headroom sizes inside a library.

Basically, you're saying that the API to create USSD messages is flawed in that it implies a fixed headroom.

I agree, but this patch doesn't really change anything about that; it merely takes the existing assumptions spread out across various functions and combines it in one place.

If We Have The Time (tm) we could enhance the API to allow for explicit buffer sizes in another patch.

Also I don't think this patch here is really important, just looked like it would be neat to tidy up a little. Feel free to drop.

-- 
To view, visit https://gerrit.osmocom.org/1341
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I029551dd74410ad6f326ce52eb7a75d912d3b875
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list