openbsc[master]: libmsc/bsc: split rate counters into bsc and msc group

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Aug 30 12:54:35 UTC 2016


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/#/c/646/5/openbsc/src/libbsc/net_init.c
File openbsc/src/libbsc/net_init.c:

Line 85: 	net->bsc_ctrs = rate_ctr_group_alloc(net, &msc_ctrg_desc, 0);
Whoa, missed this bug when accepting the patch:
Assigning twice to net->bsc_ctrs!
So you didn't test this??


-- 
To view, visit https://gerrit.osmocom.org/646
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7361033cd1eb919ec3c2ea2652f40ab8c75b2f99
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list