[PATCH] osmo-pcu[master]: Fix EGPRS EPDAN decoding: no ack nack dissector length

[arvind.sirsikar]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/766

to look at the new patch set (#5).

Fix EGPRS EPDAN decoding: no ack nack dissector length

Earlier there was an incorrect decoding of URBB fields when EPDAN is
received withot ack/Nack dissector length.This was a bottle neck
for performance testing. Which has been fixed in this patch.

Related: OS#1805

unit test assertion in the previous commit is fixed in this patch.

Change-Id: Ieddf96aca82b0b0e917cfcc70aeb978799fb4e95
---
M src/csn1.cpp
M tests/rlcmac/RLCMACTest.cpp
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/766/5

diff --git a/src/csn1.cpp b/src/csn1.cpp
index d51fe83..da5fe3b 100644
--- a/src/csn1.cpp
+++ b/src/csn1.cpp
@@ -1111,6 +1111,7 @@
           { /* extract bits */
             guint8* pui8 = pui8DATA(data, pDescr->offset);
             gint16 nB1  = no_of_bits & 0x07;/* no_of_bits Mod 8 */
+            no_of_bits -= nB1;
 
             while (no_of_bits > 0)
             {
diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp
index 4f74ea4..68a4005 100644
--- a/tests/rlcmac/RLCMACTest.cpp
+++ b/tests/rlcmac/RLCMACTest.cpp
@@ -228,7 +228,7 @@
 	 * 6 bits in the 13th byte. in 13th byte we expect value
 	 * as 0x00. But we see some incorrect value
 	 */
-	OSMO_ASSERT(strcmp(osmo_hexdump(urbb->URBB, 13),
+	OSMO_ASSERT(!strcmp(osmo_hexdump(urbb->URBB, 13),
 	"7f ff ff ee 00 00 00 00 00 00 00 00 00 "
 	));
 }

-- 
To view, visit https://gerrit.osmocom.org/766
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieddf96aca82b0b0e917cfcc70aeb978799fb4e95
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>