openbsc[master]: sms: change rp err cause of smpp_try_deliver errors

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Aug 27 01:55:21 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/551/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:

Line 298: 			LOGP(DLSMS, LOGL_ERROR, "While trying to deliver a SMS the error code %d received. Sending rp err cause 41 to ms\n", rc);
> we should create a dump of all fields. do we want to log the everything inc
we generally don't mind logging the payload of SMS so far (we do it in other places), so we could do it here, too.  But at the very least it should include the sender/recipient identities of the affected message.


-- 
To view, visit https://gerrit.osmocom.org/551
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia03e50ce2bd9a7d1054cc5a6000fd73bd3497c03
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list