[PATCH] osmo-pcu[master]: EGPRS: EPDAN decoding: add test case to show no ack_nack len...

[arvind.sirsikar]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/765

to look at the new patch set (#3).

EGPRS: EPDAN decoding: add test case to show no ack_nack len issue

This patch adds a test case itest_epdan_noack_nack_len_issue which
expects a current bug with EGPRS EPDAN decoding Ack/Nack dissector
length is not received. The test's expectation is corrected along
with the bug fix in a subsequent commit

Related: OS#1805

Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e
---
M tests/rlcmac/RLCMACTest.cpp
1 file changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/65/765/3

diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp
index 466b89e..0dbfe3f 100644
--- a/tests/rlcmac/RLCMACTest.cpp
+++ b/tests/rlcmac/RLCMACTest.cpp
@@ -30,6 +30,7 @@
 #include "pcu_vty.h"
 #include <osmocom/vty/telnet_interface.h>
 #include <osmocom/vty/logging.h>
+#include <osmocom/core/utils.h>
 #include <osmocom/core/application.h>
 }
 using namespace std;
@@ -211,6 +212,27 @@
 	bitvec_free(resultVector);
 }
 
+void test_epdan_no_ack_nack_len()
+{
+	bitvec *vector = bitvec_alloc(23);
+
+	bitvec_unhex(vector, "40200bffd161003e0e519ffffffb800000000000000000");
+	RlcMacUplink_t data;
+
+	decode_gsm_rlcmac_uplink(vector, &data);
+
+	EGPRS_AckNack_Desc_t *urbb =
+		&data.u.Egprs_Packet_Downlink_Ack_Nack.EGPRS_AckNack.Desc;
+	/*
+	 * TODO: URBB len is decoded as 102. so there is total 12 bytes and
+	 * 6 bits in the 13th byte. in 13th byte we expect value
+	 * as 0x00. But we see 0xea. Which is incorrect
+	 */
+	OSMO_ASSERT(!strcmp(osmo_hexdump(urbb->URBB, (urbb->URBB_LENGTH + 7)/8),
+	"7f ff ff ee 00 00 00 00 00 00 00 00 ea "
+	));
+}
+
 int main(int argc, char *argv[])
 {
 	osmo_init_logging(&gprs_log_info);
@@ -218,5 +240,5 @@
 	//printSizeofRLCMAC();
 	testRlcMacDownlink();
 	testRlcMacUplink();
-
+	test_epdan_no_ack_nack_len();
 }

-- 
To view, visit https://gerrit.osmocom.org/765
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>