osmo-pcu[master]: Add decoding of compressed bitmap in EPDAN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Aug 25 11:47:46 UTC 2016


Patch Set 20: Code-Review-2

(11 comments)

https://gerrit.osmocom.org/#/c/416/20/src/decoding.cpp
File src/decoding.cpp:

Line 660: 
don't move the 'int rc;' around


Line 700: 		LOGP(DRLCMACDL, LOGL_DEBUG, "Compress bitmap exist,"
in the log msg, a space is missing after the comma


Line 712: 			* bitmap has stopped here */
Don't change the whitespace, you're actually breaking it, too.


https://gerrit.osmocom.org/#/c/416/20/src/egprs_rlc_compression.cpp
File src/egprs_rlc_compression.cpp:

Line 34:  * \param idx[in] Iterate index of the code word table
what parameters are you documenting here?
You should document 'root' and 'cdwd', not the variables *inside* the function!


Line 271:  * \clr_code_bit[in] Color code 1 for Ones runlength 0 for Zero runlength
'\param'


Line 330: 			ones_list, one_run_len_code_list);
no line breaks here please, it fits on one line


https://gerrit.osmocom.org/#/c/416/20/src/egprs_rlc_compression.h
File src/egprs_rlc_compression.h:

Line 11: #include <osmocom/core/talloc.h>
not used, move to cpp file if needed there.

In general, move as many #includes as possible to the .cpp files.


Line 20: #define	MOD8(X)             (((X)+8) & (0x07))
Just use one space after '#define',
but use tabs and not spaces to align the defined values


Line 35:  */
/* single line comment */


https://gerrit.osmocom.org/#/c/416/20/tests/Makefile.am
File tests/Makefile.am:

Line 35: 	-Wl,-u,bssgp_prim_cb
Are you sure you need '-Wl,-u,bssgp_prim_cb'?


https://gerrit.osmocom.org/#/c/416/20/tests/bitcomp/BitcompTest
File tests/bitcomp/BitcompTest:

You still have the binary in the commit.
Remove it!


-- 
To view, visit https://gerrit.osmocom.org/416
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce
Gerrit-PatchSet: 20
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list