This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/766 to look at the new patch set (#2). Fix EGPRS EPDAN decoding: no ack nack dissector length Earlier there was an incorrect decoding of URBB fields when EPDAN is received withot ack/Nack dissector length.This was a bottle neck for performance testing. Which has been fixed in this patch. Related: OS#1805 unit test assertion in the previous commit is fixed in this patch. Change-Id: Ieddf96aca82b0b0e917cfcc70aeb978799fb4e95 --- M src/csn1.cpp M tests/rlcmac/RLCMACTest.cpp 2 files changed, 3 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/66/766/2 diff --git a/src/csn1.cpp b/src/csn1.cpp index d51fe83..e9437ed 100644 --- a/src/csn1.cpp +++ b/src/csn1.cpp @@ -1111,7 +1111,7 @@ { /* extract bits */ guint8* pui8 = pui8DATA(data, pDescr->offset); gint16 nB1 = no_of_bits & 0x07;/* no_of_bits Mod 8 */ - + no_of_bits -=nB1; while (no_of_bits > 0) { *pui8 = bitvec_read_field(vector, readIndex, 8); diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index 4ee99a9..816c1fa 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -31,9 +31,6 @@ #include "gprs_debug.h" extern "C" { -#if 0 -extern const struct log_info gprs_log_info; -#endif #include "pcu_vty.h" #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> @@ -233,13 +230,9 @@ EGPRS_AckNack_Desc_t *urbb = &data->u.Egprs_Packet_Downlink_Ack_Nack.EGPRS_AckNack.Desc; - /* - * TODO: URBB len is decoded as 102. so there is total 12 bytes and - * 6 bits in the 13th byte. in 13th byte we expect value - * as 0x00. But we see 0xea. Which is incorrect - */ + OSMO_ASSERT(!strcmp(osmo_hexdump(urbb->URBB, (urbb->URBB_LENGTH + 7)/8), - "7f ff ff ee 00 00 00 00 00 00 00 00 ea " + "7f ff ff ee 00 00 00 00 00 00 00 00 00 " )); } -- To view, visit https://gerrit.osmocom.org/766 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieddf96aca82b0b0e917cfcc70aeb978799fb4e95 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>