openbsc[master]: Adding LLC-XID related modifications in LLC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Aug 23 16:39:06 UTC 2016


Patch Set 13:

(1 comment)

https://gerrit.osmocom.org/#/c/652/13/openbsc/src/gprs/gprs_llc.c
File openbsc/src/gprs/gprs_llc.c:

Line 152: 				     xid_field->data);
printing the data as %s directly is not a good idea, and
you fix this in a subsequent commit using osmo_hexdump().
If we're being perfectionist rather do it here already...

...or make sure to submit both commits together.


-- 
To view, visit https://gerrit.osmocom.org/652
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65b9d625e72d3d61c99abdc7041773701d694d52
Gerrit-PatchSet: 13
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list