This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 10:
(1 comment)
one (hopefully last) thing...
https://gerrit.osmocom.org/#/c/702/10/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:
Line 753: OSMO_ASSERT(!memcmp(msg2->data, msg1->data, msg1->data_len));
This tests for identity (when fixed non-identity) of two messages.
We should rather test what's actually *in* the messages.
Like:
above for msg1:
OSMO_ASSERT(!strcmp(osmo_hexdump(msg1->data, msg1->data_len),
"01 02 03 04 [...] ff "));
here for msg2:
OSMO_ASSERT(!strcmp(osmo_hexdump(msg2->data, msg2->data_len),
"01 02 03 04 [...] ff "));
Then in the bugfix, you can adjust the actual bytes expected.
(You could then also decide to drop msg1 entirely, but in fact
it can't hurt to keep it now that it's there.)
--
To view, visit https://gerrit.osmocom.org/702
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00662a564f64c0c83627401ae8f7bfef0f0a5de8
Gerrit-PatchSet: 10
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes