This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 5: (5 comments) Almost adding my +2 but the commit log just isn't satisfactory yet... https://gerrit.osmocom.org/#/c/702/5//COMMIT_MSG Commit Message: Line 7: Describe the issue with EGPRS PUAN encoding This summary line is still unsatisfactory: "the issue" is too general and no test case mentioned. Make it: "EGPRS: PUAN encoding: add test case to show wrong urbb_len issue" Line 9: This patch is related to bug https://osmocom.org/issues/1793 (we often place a line "Related: OS#1793" in the bottom) Line 14: corrected in the subsequent commit related to this topic including "This patch adds a test case which expects a current bug with EGPRS PUAN encoding when VQ != VR. The test's expectation is corrected along with the bugfix in a subsequent commit." -- stop. I don't think we want to reference gerrit from here. In the future, you could add a gerrit comment instead. But if we look at the git history years from now, who knows whether our gerrit will still be available. If you want, you could state the commit summary line here for reference? Line 17: The test_tbf_puan_issue test describes the issue with initially "Add test_tbf_puan_issue to describe..." Actually I notice now that the test name is too general. Line 23: This is considerable issue with OTA. I would write: "Add test_tbf_puan_urbb_len to describe the following bug: EGPRS PUAN encoding disregards the urbb_len, leading to identical PUAN messages regardless of the urbb_len." (and drop all hex dumps and BSN references, they are in the code. All has been said.) -- To view, visit https://gerrit.osmocom.org/702 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00662a564f64c0c83627401ae8f7bfef0f0a5de8 Gerrit-PatchSet: 5 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes