This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/724/1//COMMIT_MSG Commit Message: Line 9: gcc6 is optimizing if (!this) {CODE} as this is assumed to never be > which "if (!this)" are you referring to? would be good will fix that in another commit. https://gerrit.osmocom.org/#/c/724/1/src/tbf.cpp File src/tbf.cpp: Line 194: return m_ms ? m_ms->llc_queue()->size() : 0; > nitpick... IMHO: I like it this way, because it's easier to read. You're right, it would be easier to change if it's using llc_queue(), because it's only a simple check on `m_ms` and it would save one in-direction through a function call. I would prefer it how it is now. -- To view, visit https://gerrit.osmocom.org/724 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88cc3180f8f86785e3f07981895dabddf50b60a2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-HasComments: Yes