This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 18: (3 comments) https://gerrit.osmocom.org/#/c/416/18/src/egprs_rlc_compression.h File src/egprs_rlc_compression.h: Line 27: extern void *tall_pcu_ctx; > If I dont declare tall_pcu_ctx as an extern I'm not able to use it in a fil you should rather declare tall_pcu_ctx in the .cpp file then. https://gerrit.osmocom.org/#/c/416/18/tests/Makefile.am File tests/Makefile.am: Line 38: -Wl,-u,bssgp_prim_cb > If I remove GB and GSM . I am not able to use LOGP. I am getting error "und That might be because you apparently have copied the TbfTest and scaled it down, instead of building up a new test from scratch? I have taken a closer look and indeed you need far less linking and #including in this test than this patch proposes. Please take a look at branch neels/416 http://git.osmocom.org/osmo-pcu/log/?h=neels/416 where I have * far less and more concise #includes; * no vty (seems to be a speciality of TbfTest, our tests usually don't include a vty); * no linking of libgprs.a, but only the single cpp file needed. Hence I don't need to link libgb and libgsm there. Does that look ok to you? I have also dropped the Bitcomptest binary from your patch and indicated a whitespace error. (If you decide to use the branch, of course all should be submitted in one patch, not three.) https://gerrit.osmocom.org/#/c/416/19/tests/bitcomp/BitcompTest File tests/bitcomp/BitcompTest: You have committed the test binary! This must not be part of the commit, instead add the binary to .gitignore. -- To view, visit https://gerrit.osmocom.org/416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce Gerrit-PatchSet: 18 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes