osmo-pcu[master]: Modify EGPRS DL TBF flow to support SPB

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Aug 20 06:59:05 UTC 2016


Patch Set 15:

(1 comment)

https://gerrit.osmocom.org/#/c/655/15/src/pcu_vty.c
File src/pcu_vty.c:

Line 490:       EGPRS_STR "DL ARQ options\n"
> Hi Neels,
I think the problem is that you use EGPRS_STR (intended for all commands starting with "egprs" for a command starting with "dl". The question thus is:
* what is the help the vty shows for a command startign with 'dl' (type ? on empty prompt)?
* is the entire command EGPRS specific? If yes, it should be "egprs dl ...".  If not, EGPRS_STR is probably the wrong help for the first word in the command.


-- 
To view, visit https://gerrit.osmocom.org/655
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I242afdd8ae7622dec8593b26382ad66bad5b9516
Gerrit-PatchSet: 15
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list