This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 4: Code-Review+1 (1 comment) would be great to remove the (probably?) unneccessary moving of #include file order. https://gerrit.osmocom.org/#/c/431/4/src/encoding.h File src/encoding.h: Line 43: bitvec * dest, uint8_t downlink, uint16_t ra, > It is not obvious why this is changed to uint16_t, maybe describe in the co the patch is about 11bit rach. I think it is rather obvious that this won't fit into uint8_t. -- To view, visit https://gerrit.osmocom.org/431 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5e309156e5dbbb6add74a1b4d257c4ee2332e52 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-HasComments: Yes