[PATCH] openbsc[master]: lchan: Release channel in case of late activation ack

[Holger Freyther]

Review at  https://gerrit.osmocom.org/713

lchan: Release channel in case of late activation ack

In case of the sysmoBTS and receiving a channel activation ack on
a channel that was marked as broken, release it again.

Use a normal release without SACCH deactivation and release the
rqd_ta data.

Change-Id: I63dc0deaf15ba7c21e20b1e0c7b85f0437e183ed
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/13/713/1

diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index 9f76280..091d179 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -983,8 +983,17 @@
 	osmo_timer_del(&msg->lchan->act_timer);
 
 	if (msg->lchan->state == LCHAN_S_BROKEN) {
-		LOGP(DRSL, LOGL_NOTICE, "%s CHAN ACT ACK for broken channel.\n",
-			gsm_lchan_name(msg->lchan));
+		int do_free = is_sysmobts_v2(msg->lchan->ts->trx->bts);
+		LOGP(DRSL, LOGL_NOTICE, "%s CHAN ACT ACK for broken channel. %s\n",
+			gsm_lchan_name(msg->lchan),
+			do_free ? "Release it" : "Keeping it broken");
+		if (do_free) {
+			talloc_free(msg->lchan->rqd_ref);
+			msg->lchan->rqd_ref = NULL;
+			msg->lchan->rqd_ta = 0;
+			rsl_lchan_set_state(msg->lchan, LCHAN_S_ACTIVE);
+			rsl_rf_chan_release(msg->lchan, 0, SACCH_NONE);
+		}
 		return 0;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/713
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63dc0deaf15ba7c21e20b1e0c7b85f0437e183ed
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>