This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 21: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/644/21/openbsc/src/gprs/sgsn_main.c
File openbsc/src/gprs/sgsn_main.c:
Line 302: .description = "V42.bis data compression (SNDCP)",
Isn't it V.42bis?
https://gerrit.osmocom.org/#/c/644/21/openbsc/tests/v42bis/v42bis_test.c
File openbsc/tests/v42bis/v42bis_test.c:
Line 39: struct v42bis_output_buffer_t {
in a test case I don't mind, but generally we don't call structures _t.
--
To view, visit https://gerrit.osmocom.org/644
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I689413f2541b6def0625ce6bd96f1f488f05f99d
Gerrit-PatchSet: 21
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes