[MERGED] osmo-bts[master]: sysmo: fix dyn TS: Revert "Activate PTCCH UL" [in sysmobts]

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Aug 12 12:07:05 UTC 2016


Neels Hofmeyr has submitted this change and it was merged.

Change subject: sysmo: fix dyn TS: Revert "Activate PTCCH UL" [in sysmobts]
......................................................................


sysmo: fix dyn TS: Revert "Activate PTCCH UL" [in sysmobts]

This reverts commit 53d792c3b027bfb42d77804e3e687a287e122ef3.
See http://osmocom.org/issues/1796

The commit caused this error for PDCH TS with SysmoBTS:

DL1P <0007> l1_if.c:164 Tx L1 prim MPH-ACTIVATE.req
DL1C <0006> oml.c:811 Error activating L1 SAPI PTCCH on TS 7: Invalid parameter
DL1C <0006> oml.c:1089 (bts=0,trx=0,ts=7,ss=0) act failed mark broken due status: -4

Plain PDCH TS show this error but continue to function despite the SAPI
activation failure.

As a side effect, the SAPI activation failure breaks dynamic TS. GPRS
initially works, but the broken status prevents transitions to TCH/* modes
in the BSC:

DRLL <0000> chan_alloc.c:355 Failed to allocate TCH_H channel
DRSL <0004> abis_rsl.c:1656 BTS 0 CHAN RQD: no resources for TCH_H 0x45

Since the commit only enabled PTCCH UL in sysmobts, no other BTS models are
affected. Notice that lc15 still has PTCCH UL disabled all the while, before
and after this commit and its revert.

Also note that PTCCH DL is and has been enabled without problems (see
further above in sapi_dir_pdtch_sapis[]). This is only about PTCCH UL.

Related: OS#1796
Change-Id: Ia59d95c75a8a5d3bd596f55cd1dc0906a6a95f7f
---
M src/osmo-bts-sysmo/oml.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c
index 9beba43..e5d3e40 100644
--- a/src/osmo-bts-sysmo/oml.c
+++ b/src/osmo-bts-sysmo/oml.c
@@ -618,9 +618,8 @@
 	{ GsmL1_Sapi_Pdtch,	GsmL1_Dir_RxUplink },
 	{ GsmL1_Sapi_Ptcch,	GsmL1_Dir_TxDownlink },
 	{ GsmL1_Sapi_Prach,	GsmL1_Dir_RxUplink },
-	{ GsmL1_Sapi_Ptcch,	GsmL1_Dir_RxUplink },
-	/* FIXME: do we still need this if? */
 #if 0
+	{ GsmL1_Sapi_Ptcch,	GsmL1_Dir_RxUplink },
 	{ GsmL1_Sapi_Pacch,	GsmL1_Dir_TxDownlink },
 #endif
 };

-- 
To view, visit https://gerrit.osmocom.org/671
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia59d95c75a8a5d3bd596f55cd1dc0906a6a95f7f
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels_test_account <neels at hofmeyr.de>



More information about the gerrit-log mailing list