This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 10: (2 comments) https://gerrit.osmocom.org/#/c/655/10/src/pcu_vty.c File src/pcu_vty.c: PS10, Line 133: why the extra space at the end of the line? we never use this anywhere else when writing config files, as far as i know. https://gerrit.osmocom.org/#/c/655/10/src/rlc.cpp File src/rlc.cpp: PS10, Line 427: 3 where is the '3' defined here? How does it relate to the comment above? i.e. where should the reader know from that '3' indicates "second segment of block"? I don't know the GPRS related specs, but if it is some kind of enumeration, an actual enum or #define might be useful. -- To view, visit https://gerrit.osmocom.org/655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I242afdd8ae7622dec8593b26382ad66bad5b9516 Gerrit-PatchSet: 10 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes