[MERGED] libosmocore[master]: configure: check for pkg-config presence

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: configure: check for pkg-config presence
......................................................................


configure: check for pkg-config presence

On a fresh installation, I was puzzled by a configure.ac 'syntax error' for
PKG_CHECK_MODULES(TALLOC). It took me some time to figure out that merely
pkg-config was missing.

Add a check for pkg-config, which isn't as straightforward as I would wish,
so comment generously.

Change-Id: I2e7cdc37eb59f9947a45fbc5baddbaf71b655bc0
---
M configure.ac
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index 33c9b5c..1b62278 100644
--- a/configure.ac
+++ b/configure.ac
@@ -17,6 +17,21 @@
 
 AC_CONFIG_MACRO_DIR([m4])
 
+dnl check for pkg-config
+dnl * If pkg-config is missing, we get a "syntax error" for PKG_CHECK_MODULES.
+dnl   Instead, we want to say that pkg-config and pkg.m4 are missing.
+dnl * The proper way is PKG_PROG_PKG_CONFIG() but unfortunately that does not
+dnl   produce an intelligible error message if pkg-config is missing entirely
+dnl   ("syntax error near unexpected token `0.20'").
+dnl * To produce a hint that pkg-config is missing, check for the pkg-config
+dnl   binary; but AC_PATH_PROG breaks if the distribution provides only
+dnl   prefixed (<arch>-pkg-config) versions, so just print a warning.
+AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no)
+if test "x$PKG_CONFIG_INSTALLED" = "xno"; then
+        AC_MSG_WARN([You need to install pkg-config])
+fi
+PKG_PROG_PKG_CONFIG([0.20])
+
 dnl check os: some linker flags not available on osx
 case $host in
 *-darwin*)

-- 
To view, visit https://gerrit.osmocom.org/663
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7cdc37eb59f9947a45fbc5baddbaf71b655bc0
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels_test_account <neels at hofmeyr.de>