This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/655/6/src/pcu_vty.c File src/pcu_vty.c: PS6, Line 490: <0-1> [<0-1>] * why is there a second optional argument that is not used in the code? * when the choice os only 0 or 1, better to use (0|1) instead of <0-1>. This way you can document each choice value separately for proper interactive context-sensitive help. Line 493: "0:Reseg, 1:no Reseg") have you seen this syntax/description for help used anywhere else in the code? if so, please report it to our attention. -- To view, visit https://gerrit.osmocom.org/655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I242afdd8ae7622dec8593b26382ad66bad5b9516 Gerrit-PatchSet: 6 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes