This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pravin gerrit-no-reply at lists.osmocom.orgPatch Set 8: > > (1 comment) > > I am afraid most comments still stand. > > * Wrong usage of talloc > * T4 support not in a standalone file (making moving it back to > libosmocore difficult) New context tall_tree_ctx is created under tall_pcu_ctx and this new context is used for memory allocation of tree nodes. All functions are defined in a standalone file egprs_rlc_compression.cpp. Currently function decompress_crbb is part of class Decoding. We will remove the declaration from decoding.h and add it in egprs_rlc_compression.h. Please confirm if your comment refers to the same. -- To view, visit https://gerrit.osmocom.org/416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce Gerrit-PatchSet: 8 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: No