This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/649/1/src/ctrl/control_if.c File src/ctrl/control_if.c: Line 126: int ctrl_cmd_send_trap(struct ctrl_handle *ctrl, char *name, char *value) > why mutable? Who owns name and value? Because I have not found a way to make it const without adding extra warnings - advices are appreciated. The problem is that it's called by openggsn which does not use talloc. The values are owned by caller for the time being but I don't mind changing it - those are created just for this function so it doesn't really matter from caller's perspective. -- To view, visit https://gerrit.osmocom.org/649 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b8d88c4f5c4d42c3f8fb754f8eabf049c9e388 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes