This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/652/2/openbsc/src/gprs/gprs_llc.c File openbsc/src/gprs/gprs_llc.c: Line 46: * FIXME: Remove this switch as soon as the XID integration in white space at end of line. Even marked in dark red in gerrit to make you aware of it. Thre are plenty of them, not only in this file / patch. Please try to pay attention to that. PS2, Line 107: int iov_ui why is iov_ui a signed integer? Are you sure that's what llme->iov_ui currently is? Line 110: /* see my other comment on wasting lines for comment start/end PS2, Line 125: randomly select there is no random selection, the entire comment can be removed. -- To view, visit https://gerrit.osmocom.org/652 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b9d625e72d3d61c99abdc7041773701d694d52 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-HasComments: Yes