openbsc[master]: V42BIS integration

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Aug 1 18:33:17 UTC 2016


Patch Set 1: Code-Review-1

(2 comments)

pleae split the pcomp(slhc) and dcomp(v42) in different topic branches, and not have them in one 'compression' topic branch.

https://gerrit.osmocom.org/#/c/644/1/openbsc/include/openbsc/v42bis.h
File openbsc/include/openbsc/v42bis.h:

Line 68
Leaving this identical with the original code might make sense.  It doesn't hurt to have this c++ compatibility stuff..


Line 78
it might make sense to simply have a
#define SPAN_DECLARE(x) x
and keep the original code as-is.  Makes it easier if we ever have to apply any upstream patches/fixes to our copy without too many fixes.


-- 
To view, visit https://gerrit.osmocom.org/644
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689413f2541b6def0625ce6bd96f1f488f05f99d
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list