From axilirator at gmail.com Sun Oct 22 16:03:10 2017 From: axilirator at gmail.com (Vadim Yanitskiy) Date: Sun, 22 Oct 2017 19:33:10 +0330 Subject: layer23/mobile: VTY is broken Message-ID: On 22 October 2017 at 19:20, Snehasish Kar wrote: > Hello Vadim > > I tried using your trxcon along with grgsmtrx, > but when i start the app mobile in the l2l3 software > it gives me the following error: > > Assert failed !check_element_exists(cnode, cmd->string) command.c:627 > backtrace() returned 7 addresses > /usr/local/lib/libosmovty.so.3(install_element+0x136) [0x7f7a8c7fd4b6] > ./mobile() [0x43d371] > ./mobile() [0x40548e] > ./mobile() [0x4049e7] > /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f7a8bffaf45] > ./mobile() [0x404a83] > > Please help. Hi, This message was forwarded to the ML. Please do the same in the future to make others able to know about the problem and possible solutions. Actually, this crash isn't related to trxcon application anyhow, it's caused by the recent libosmocore changes, related to the VTY default nodes. A quick solution would be to drop all custom 'exit' commands from the 'vty_interface.c'. I'll try to fix the problem in spare time... If you have some time and feel yourself able to write a proper fix, just send me a patch, and I'll review one ASAP ;) BTW: we have some updates regarding to TX support. Please look at the 'origin/ptrkrysik/trx' and 'axilirator/fixeria/trx' on GitHub. With best regards, Vadim Yanitskiy. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nhofmeyr at sysmocom.de Sun Oct 22 19:11:51 2017 From: nhofmeyr at sysmocom.de (Neels Hofmeyr) Date: Sun, 22 Oct 2017 21:11:51 +0200 Subject: layer23/mobile: VTY is broken In-Reply-To: References: Message-ID: <20171022191151.GC19965@my.box> On Sun, Oct 22, 2017 at 07:33:10PM +0330, Vadim Yanitskiy wrote: > > I tried using your trxcon along with grgsmtrx, > > but when i start the app mobile in the l2l3 software > > it gives me the following error: > > > > Assert failed !check_element_exists(cnode, cmd->string) command.c:627 > > backtrace() returned 7 addresses > > /usr/local/lib/libosmovty.so.3(install_element+0x136) [0x7f7a8c7fd4b6] > > ./mobile() [0x43d371] > > ./mobile() [0x40548e] > > ./mobile() [0x4049e7] > > /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f7a8bffaf45] > > ./mobile() [0x404a83] > > > > Please help. > > Actually, this crash isn't related to trxcon application > anyhow, it's caused by the recent libosmocore changes, > related to the VTY default nodes. A quick solution would > be to drop all custom 'exit' commands from the > 'vty_interface.c'. Then it should be my fault. Can I do anything to help fix it? Can you explain why custom 'exit' commands need to be dropped? That shouldn't be the case for a telnet VTY, only while reading in VTY config from a file. ~N -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From axilirator at gmail.com Sun Oct 22 21:12:25 2017 From: axilirator at gmail.com (Vadim Yanitskiy) Date: Mon, 23 Oct 2017 00:42:25 +0330 Subject: layer23/mobile: VTY is broken In-Reply-To: <20171022191151.GC19965@my.box> References: <20171022191151.GC19965@my.box> Message-ID: Hi Neels, > Can you explain why custom 'exit' commands need to > be dropped? That shouldn't be the case for a telnet > VTY, only while reading in VTY config from a file. I think, this happens due to the following change: 22bc45b8bfb8d0f2d8a46c6e945f3b4388fdced0 since which every application does install default commands by default, including 'exit' and 'end'. At the moment there are the custom 'exit' and 'end' commands in the OsmocomBB/mobile/vty_interface.c. So, the crash happens because it attempts to install already existing commands. > Then it should be my fault. Can I do anything > to help fix it? I've prepared a fix for that, have a look please: https://gerrit.osmocom.org/4373 Also, I've fixed one more thing by the way: https://gerrit.osmocom.org/4374 With best regards, Vadim Yanitskiy. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nhofmeyr at sysmocom.de Mon Oct 23 01:54:40 2017 From: nhofmeyr at sysmocom.de (Neels Hofmeyr) Date: Mon, 23 Oct 2017 03:54:40 +0200 Subject: layer23/mobile: VTY is broken In-Reply-To: References: <20171022191151.GC19965@my.box> Message-ID: <20171023015440.GC20477@my.box> On Mon, Oct 23, 2017 at 12:42:25AM +0330, Vadim Yanitskiy wrote: > At the moment there are the custom 'exit' and 'end' > commands in the OsmocomBB/mobile/vty_interface.c. > So, the crash happens because it attempts to install > already existing commands. Ah, damn. I checked all of the repositories I know to use the VTY, I didn't imagine that OsmocomBB also has a VTY. That's really my fault then. Lucky for me that the BB custom ones seem to merely dup the libosmocore stock ones, so I get away with your patch: > https://gerrit.osmocom.org/4373 > Also, I've fixed one more thing by the way: > https://gerrit.osmocom.org/4374 well done. Thanks for saving my A ~N -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From laforge at gnumonks.org Mon Oct 23 10:36:53 2017 From: laforge at gnumonks.org (Harald Welte) Date: Mon, 23 Oct 2017 12:36:53 +0200 Subject: layer23/mobile: VTY is broken In-Reply-To: <20171023015440.GC20477@my.box> References: <20171022191151.GC19965@my.box> <20171023015440.GC20477@my.box> Message-ID: <20171023103653.emer6z4bpclktsrf@nataraja> Hi guys, I have this in the gerrit/laforge/ournode-vty since October 14, and thre was some discussion either on the ML or on redmine about it, otherwise I wouldn't have written it at the time, while on holidays. Regards, Harald On Mon, Oct 23, 2017 at 03:54:40AM +0200, Neels Hofmeyr wrote: > On Mon, Oct 23, 2017 at 12:42:25AM +0330, Vadim Yanitskiy wrote: > > At the moment there are the custom 'exit' and 'end' > > commands in the OsmocomBB/mobile/vty_interface.c. > > So, the crash happens because it attempts to install > > already existing commands. > > Ah, damn. I checked all of the repositories I know to use the VTY, I didn't > imagine that OsmocomBB also has a VTY. That's really my fault then. > > Lucky for me that the BB custom ones seem to merely dup the libosmocore stock > ones, so I get away with your patch: > > > https://gerrit.osmocom.org/4373 > > > Also, I've fixed one more thing by the way: > > https://gerrit.osmocom.org/4374 > > well done. > > Thanks for saving my A > > ~N -- - Harald Welte http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6) From laforge at gnumonks.org Mon Oct 23 10:43:52 2017 From: laforge at gnumonks.org (Harald Welte) Date: Mon, 23 Oct 2017 12:43:52 +0200 Subject: layer23/mobile: VTY is broken In-Reply-To: <20171023015440.GC20477@my.box> References: <20171022191151.GC19965@my.box> <20171023015440.GC20477@my.box> Message-ID: <20171023104352.fwsnw36rkptwi5gl@nataraja> Hi Neels, On Mon, Oct 23, 2017 at 03:54:40AM +0200, Neels Hofmeyr wrote: > Ah, damn. I checked all of the repositories I know to use the VTY, I didn't > imagine that OsmocomBB also has a VTY. That's really my fault then. I think in general we should not fall into that trap. We have *no clue* at all who might be using libosmo* for whatever purpose. If we provide a libary with a given API/ABI, then it's our responsibility to keep that ABI/API as stable as possible. I understand that it was hardly possible without fall-out in that particular case, and for sure there are exceptions. However, completely unrelated to this particular topic (and hence the Cc to openbsc@) I'm not happy in general with the way how "carlessly" we sometimes introduce breakage. We have to be more disciplined in general on this. All of us. BTW: The fact that this change has gone into master without being noticed also means that possibly we're not modelling osmocom-bb as a downstream user of libosmocore that needs to be rebuilt (and at least checked if it starts up correctly?) whenever testing a libosmocore change. That's also something to investigate. Maybe there's some way we can test this without too much effort. Regards, Harald -- - Harald Welte http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6) From nhofmeyr at sysmocom.de Mon Oct 23 14:24:57 2017 From: nhofmeyr at sysmocom.de (Neels Hofmeyr) Date: Mon, 23 Oct 2017 16:24:57 +0200 Subject: layer23/mobile: VTY is broken In-Reply-To: <20171023104352.fwsnw36rkptwi5gl@nataraja> References: <20171022191151.GC19965@my.box> <20171023015440.GC20477@my.box> <20171023104352.fwsnw36rkptwi5gl@nataraja> Message-ID: <20171023142457.GB2123@my.box> On Mon, Oct 23, 2017 at 12:43:52PM +0200, Harald Welte wrote: > I think in general we should not fall into that trap. We have *no clue* at all > who might be using libosmo* for whatever purpose. If we provide a libary with > a given API/ABI, then it's our responsibility to keep that ABI/API as stable as > possible. True. There are ways to fix this one: we can allow to register a given command a second time, which then replaces the previously registered command. We can also allow this only for the common node commands. Should I implement this? Then upon new release, all potential VTY users out there can still register their own common node commands to replace the default ones and should not experience breakage. ~N -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From hwelte at sysmocom.de Tue Oct 31 19:31:35 2017 From: hwelte at sysmocom.de (Harald Welte) Date: Tue, 31 Oct 2017 20:31:35 +0100 Subject: Want to do paid work on Osmocom? sysmocom is hiring Message-ID: <20171031193135.gxecyt7iy4gig7qh@nataraja> Dear Osmocom community, I would like to point out that at sysmocom, we're currently (again) hiring [1]. If you happen to have an interest in open source cellular communications and are fluent in C language development, we would love to hear from you. sysmocom probably doesn't need any introduction here, but just in case: The company was founded by Holger Freyther and Harald Welte, two of the leading OpenBSC and Osmocom developers from the very early days of the project. Today we are responsible for by far the largest number of commits to the Osmocom GSM/3G infrastructure related git repositories. Among our current priorities are automatic testing for the GPRS PCU, generalization of the OsmoMGW media gateway, support for load-based hand-over, inter-BSC hand-over as well as various improvements on the lower layers of the GPRS protocol stack. We're very dedicated to the cause in furthering the capabilities of open source cellular infrastructure from 2G to 4G. We believe in working upstream, no open core or dual licensing. If you have an interest working with an enthusiastic, strong technical and dedicated team of Osmocom hackers, please don't hesitate to let me know, best by e-mail to jobs at sysmocom.de Thanks, Harald p.s.: I hope this kind of message is not disturbing to anyone. I think it is important to the Osmocom project to have more paid people working on the stack, so it is justified. The positions we are seeking to fill will work [almost exclusively] on Osmocom, so it's not a random job ad but in the very interest of Osmocom, and hence on-topic for this list. [1] https://www.sysmocom.de/jobs/ -- - Harald Welte http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte