Hi Steve,

Awesome thanks! I've attached the patch file here, hopefully this works. I've made some additional changes to remove the compiler warnings the previous patch was giving too.

If you or anyone at Osmocom needs a V4 unit for testing please send me an email privately with address details.

Regards,
Carl


On Tue, Aug 22, 2023 at 12:58 AM Steve Markgraf <steve@steve-m.de> wrote:
Hi Carl,

On 18.08.23 08:34, Carl Laufer wrote:
> I've just released a new R828D based dongle and it needs some code
> changes to work. It would be great if the osmocom drivers could support it.
>
> The dongle is based on the R828D chip, but unlike prior R828D dongles
> which use 16 MHz, the V4 uses a 28.8 MHz LO. Also the three RF inputs
> are used, and connected via a triplexer to separate them into HF, VHF
> and UHF bands. Finally, the open_d pin is also used to activate some
> notch filters for common interference bands.
>
> I've written the code so it detects an EEPROM string in the V4, and only
> applies the new code if that exists. This makes sure that the older
> R828D based dongles still work.
>
> I'm not too familiar with the patch submission process, so please let me
> know if something needs to be changed.  And if anyone on the team
> needs/wants some new V4 dongles for testing, please let me know too.

Okay, sounds good, I would like to merge the patch.

Unfortunately your mail seems to have been sent as HTML mail and all
intendations are broken, so I cannot amend your patch. Can you please
send it again in the git format-patch format or as an attachment?

Regards,
Steve