Hello.

"Bearer control mode" is added in Release 7 as I am aware of. It's not vendor specific.

You can check here: http://www.tech-invite.com/3m29/tinv-3gpp-29-060.html

"If Bearer Control Mode is provided by the GGSN in the PCO, the Bearer Control Mode IE shall be included in order to inform the SGSN about the bearer control mode and shall indicate the same bearer control mode as indicated to the MS in the PCO."

Wireshark (I'm using latest version) decodes this information element with no problem.

There's probably a method to select Release used by GGSN but the GGSN tests were done on is in a live mobile network and doing configuration changes on it is not an option.

I will make those changes in these files in a proper way so there's no confusion what is added and what is deleted (actually nothing is deleted).

I will use git send-email/git format-patch. I suppose the e-mail to send is the same (osmocom-net-gprs@lists.osmocom.org)?

Greetings.

2016-09-14 0:43 GMT+02:00 Neels Hofmeyr <nhofmeyr@sysmocom.de>:

Thanks for your patch!
It looks good in principle, but let's clarify some details.

I can't find the 'Bearer Control Mode' in the GTP spec I have here (ETSI TS 129
060 V6.9.0 (2005-06) / 3GPP TS 29.060 version 6.9.0 Release 6), so it looks
like a vendor specific extension. You don't happen to have a spec on it?

Your patch includes some unwanted whitespace changes, it would be great to get
rid of those. I'm marking them below:

On Tue, Sep 13, 2016 at 10:00:37AM +0200, BJovke . wrote:
> - if (j < GTPIE_SIZE) {
> + case GTPIE_BCM:
> + if (j < GTPIE_SIZE) {

The 'if (j...' line shouldn't change.

> - iesize = 2;
> + case GTPIE_BCM:
> + iesize = 2;

The iesize line shouldn't change. (x2)

In fact, those whitespace changes look weird, because in the upstream file
version, the indenting you're apparently adding is already present.

It is easiest for us if you submit your patch using git send-email, or at least
git format-patch, which also ensures that we get a commit log message and
author information, and that the patch is based on our master HEAD.

It would be great if you could resolve these issues. Thanks again!

~Neels

--
- Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Harald Welte

Jovan Bunjevački.