From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Wed, 26 Dec 2012 10:33:10 +0100 Message-ID: Subject: openbsc.git branch master updated. 0.12.0-196-gc121bb3 Message: 10 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via c121bb3188445dfc23a6daef3444031f447395bb (commit) from 006e3d87e019b202a38c5393ab8f5b6df763e664 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/openbsc/commit/?id=c121bb3188445dfc23a6daef3444031f447395bb commit c121bb3188445dfc23a6daef3444031f447395bb Author: Holger Hans Peter Freyther Date: Wed Dec 26 10:17:42 2012 +0100 handover: Fix the handover signalling for IP based BTSes This was reported by Kevin when he was testing handover. The problem is the order of the signal handlers for S_ABISIP_CRCX_ACK. Right now the handover signal handler is called before the one inside the libmsc gsm_04_08.c. This means S_HANDOVER_ACK is signalled _before_ there is a rtp socket created for the channel. The result is that the MDCX will never be sent and the called will not be properly switched _after_ the handover detection. I do not want to play with the order of signal handlers, remove the CRCX ack handling from the handover_logic.c and force the NITB (and later the BSC) to check if the lchan is involved with a handover and do the switching in there. This means right now we do what two signal handlers did in one. Reproduced and tested with the FakeBTS Handover test. Log message: <0004> abis_rsl.c:1954 (bts=1,trx=0,ts=3,ss=0) IPAC_CRCX_ACK ... <000c> gsm_04_08.c:1400 no RTP socket for new_lchan <001a> rtp_proxy.c:533 rtp_socket_create(): success <001a> rtp_proxy.c:615 rtp_socket_bind(rs=0x48703c8, IP=0.0.0.0): ... ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/handover.h | 3 ++ openbsc/include/openbsc/signal.h | 10 --------- openbsc/src/libbsc/handover_logic.c | 35 ++++++++------------------------ openbsc/src/libmsc/gsm_04_08.c | 33 ++++++++++++++++++------------ openbsc/src/osmo-bsc/osmo_bsc_audio.c | 4 +++ 5 files changed, 36 insertions(+), 49 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)