From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Tue, 23 Sep 2014 14:35:09 GMT Message-ID: <201409231435.s8NEZ9ff089686@git.osmocom.org> Subject: libosmocore.git branch master updated. 0.7.0-15-ga39e2de Message: 2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via a39e2deff8f12f164f8a88fb061c66626bfe22a5 (commit) via b83b838bd1d0d4f3fe9d699e886634fe7d90f420 (commit) via a7165778c6696a8853bc7696ffed29dd757b4b0f (commit) from de883e7f6cfb71f46921d6ef7564b24aeecd6f2c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=a39e2deff8f12f164f8a88fb061c66626bfe22a5 commit a39e2deff8f12f164f8a88fb061c66626bfe22a5 Author: Jacob Erlbeck Date: Tue Sep 23 13:28:24 2014 +0200 gprs: Set bssgph field in bssgp_msgb_alloc() Currently the bssgph field is not set when using the bssgp_tx_* functions. This hinders unit testing of generated messages. This patch initializes the bssgph field directly after allocation a new bssgp msgb in bssgp_msgb_alloc() so that it is set by default. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=b83b838bd1d0d4f3fe9d699e886634fe7d90f420 commit b83b838bd1d0d4f3fe9d699e886634fe7d90f420 Author: Jacob Erlbeck Date: Tue Sep 23 13:28:22 2014 +0200 gprs: Fix bssgp_rcvmsg to handle signalling msgs with BVCI IE Currently BSSGP messages with an NS BVCI of 0 (signalling) are discarded if they aren't RESET messages. Thus valid signalling messages (e.g. BLOCK) are not handled properly, because the BVCI IE is ignored if it present. Instead a STATUS message referring to BVCI 0 (instead of the BVCI used in the BLOCK message) is returned. This patch changes the implementation to use the BVCI contained in the BVCI IE if that is present in a signalling message. It fixes BSSGP BLOCK/UNBLOCK for the osmo-sgsn. Note that signalling messages without an BVCI IE (e.g. SUSPEND/RESUME) are still rejected. Ticket: OW#1205 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=a7165778c6696a8853bc7696ffed29dd757b4b0f commit a7165778c6696a8853bc7696ffed29dd757b4b0f Author: Jacob Erlbeck Date: Tue Sep 23 13:28:21 2014 +0200 gprs: Fix and check BVCI in BSSGP STATUS messages Currently the BVCI is not set in all invocations to bssgp_tx_status() when the cause is UNKNOWN_BVCI. This patch adds the argument where it is missing. It also adds a check for compliance (GSM 08.18, 10.4.14.1) to bssgp_tx_status() to emit errors when the following requirement is not fulfilled: The BVCI must be included if (and only if) the cause is either "BVCI blocked" or "BVCI unknown". Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/gb/gprs_bssgp.c | 10 +++++++--- src/gb/gprs_bssgp_util.c | 18 +++++++++++++++++- 2 files changed, 24 insertions(+), 4 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications