From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Fri, 25 Jan 2013 11:57:58 +0100 Message-ID: Subject: osmo-bts.git branch zecke/channel-release updated. 0.1.0-67-ge69c095 Message: 1 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, zecke/channel-release has been updated discards 982708cda1f36871a14b7e036aa944b103e74f96 (commit) discards dce43793d0e061dd710e912f721fc31145a8322c (commit) discards 7e13242346acc2c3fa9bbb1708a0699551ad1703 (commit) discards 3a220297203479f1720d015d747bff40d04d8d0a (commit) discards 057d10ff8c74aa658806bd9182a8864df140ac02 (commit) discards 228d6e576359e7fc3950c36c84d59c38dd0767bf (commit) discards f1ccf838a9118922a159ebbd4db522191c6224f8 (commit) discards ee762c1ff006b464ccb673be350c0585e543bc9a (commit) discards 4cfe43e82705887db0a289d6538522fd58b441da (commit) discards 4b7d1ba5ac8c9d8483bc36b35654338f76b6e5eb (commit) discards d8755f5cbe7311cc06a0690edde88a9f3fe9d7ca (commit) discards 4c020635be485db202417d3982c31bca07498506 (commit) discards ec1a84e5ec3e90aec5949b87e9ccff812a68bb65 (commit) discards 4caede7fdd2474cc446a76ac4cfb93fccf95d3e3 (commit) discards 84d63242483ed33af696b680ea73abe00dcb8104 (commit) discards 0002ca684df9ac53213d47b110125ab7bdddded8 (commit) discards 7a0ab3f99580af30dd50777d0888cbcfbbe00423 (commit) discards 53a812621ff4eef72b2765a22aaa1d3e7d42b666 (commit) discards 949d90659e73b0579dc901e924e27090d4e92d64 (commit) via e69c0956abd94f7c7973add65e611682a6054045 (commit) via 709098c73c8b844af14820175ad70fa1eb296fb0 (commit) via 6967510511933f2e1682ed978e893d2ba93398a7 (commit) via e10df9281fa0c04afab84932f5ac70b8a8a49d03 (commit) via ff5a1fab8dc3a38130257c751c4d5b9a492b8db3 (commit) via 64554f0d589b9e57d6b4ec0fcf034f108351f44a (commit) via 945b3dbaaa4db42e4e5417f1372981e6e9fb56f7 (commit) via eb95e4535d4606e8e889b67d1d538108b6b0ab45 (commit) via aab241f28dc1ed01066a71b76a57b61ef43d5111 (commit) via c9bd31fdd5fc8c85b0e792a06667bf61881bca83 (commit) via 2a600b751b273a2dd798b0ac1ae8b85a39b06cf6 (commit) via 1163e109dfac7e5de0498a93167758cd7154d167 (commit) via 817c95f80c32f24c4c6a768e83ebd801f62e9cf1 (commit) via c7460351dab1a86484700ea395c686981bd7d23d (commit) via cf95ad191c42ad5f487d4ad1be411ec0179a83fe (commit) via d8002eb6c2869612b39f8a8357e7a31665b1bec8 (commit) via 90409c293f484f4032360c7fa5034f2653319861 (commit) via bc7af9522f3733683d7c317bdb4ba94ddbc84343 (commit) via f4010fcd6a0e44d3af972ba5168afe2a809854b8 (commit) via 1697cd9bb0a522d9cb084041e0f053dd09194869 (commit) via 662f868be19f8ce062422b4e15f37cd671ba42f7 (commit) via bcd50d32195f0a73b95b6f21cdc58a548e4d6bdb (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (982708cda1f36871a14b7e036aa944b103e74f96) \ N -- N -- N (e69c0956abd94f7c7973add65e611682a6054045) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=e69c0956abd94f7c7973add65e611682a6054045 commit e69c0956abd94f7c7973add65e611682a6054045 Author: Holger Hans Peter Freyther Date: Wed Jan 23 17:36:14 2013 +0100 WIP... try to overcome the short coming http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=709098c73c8b844af14820175ad70fa1eb296fb0 commit 709098c73c8b844af14820175ad70fa1eb296fb0 Author: Holger Hans Peter Freyther Date: Fri Jan 25 11:22:25 2013 +0100 tests: Share the stub between the paging and ciphering tests http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=6967510511933f2e1682ed978e893d2ba93398a7 commit 6967510511933f2e1682ed978e893d2ba93398a7 Author: Holger Hans Peter Freyther Date: Fri Jan 25 11:07:12 2013 +0100 sysmobts: Improve the shutdown of the DSP on exit Issue the RfDeactivate.REQ before sending the MphClose.REQ. Ideally we would issue MphClose.REQ after the RfDeactivate.CNF but this is not possible right now. The current approach makes the following warning of the DSP go away on shutdown. This was tested with my E71 and a silent-call using a SDCCH. DSP Warning: [ERROR] : DeviceMng_ValidateL1Handle() => Invalid layer 1 handle http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=e10df9281fa0c04afab84932f5ac70b8a8a49d03 commit e10df9281fa0c04afab84932f5ac70b8a8a49d03 Author: Holger Hans Peter Freyther Date: Thu Jan 24 12:00:14 2013 +0100 sysmobts: Re-load the FPGA image and let some time pass before continuing We are not cleanly shutting down the DSP on exit so let us reset both the DSP and the FPGA. Also let some time pass to allow the DSP to properly initialize itself before starting to use it. This is not a fix but a band-aid for the unclean shutdown. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=ff5a1fab8dc3a38130257c751c4d5b9a492b8db3 commit ff5a1fab8dc3a38130257c751c4d5b9a492b8db3 Author: Holger Hans Peter Freyther Date: Sun Jan 20 11:35:48 2013 +0100 measurement: Add debug helper when we have a report for an inactive channel http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=64554f0d589b9e57d6b4ec0fcf034f108351f44a commit 64554f0d589b9e57d6b4ec0fcf034f108351f44a Author: Holger Hans Peter Freyther Date: Tue Jan 22 15:45:14 2013 +0100 sysmobts: Prepare to address the documented limitation of this code http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=945b3dbaaa4db42e4e5417f1372981e6e9fb56f7 commit 945b3dbaaa4db42e4e5417f1372981e6e9fb56f7 Author: Holger Hans Peter Freyther Date: Tue Jan 22 15:36:49 2013 +0100 sysmobts: Fix a memory leak when no callback is set The TxPower handled used to call the requestion function without a callback. In that case the msgb is leaked. The code still allows the callback to be NULL so we will just delete the message in that case. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=eb95e4535d4606e8e889b67d1d538108b6b0ab45 commit eb95e4535d4606e8e889b67d1d538108b6b0ab45 Author: Holger Hans Peter Freyther Date: Tue Jan 22 15:22:55 2013 +0100 sysmobts: Remove the is_system_primitive from l1if_req_compl All users (but the gsm_compl) of the l1if_req_compl use it with is_system_primitive=1. We can now remove this parameter from the method. Introduce _l1if_req_compl that will insert the item into the queue for us. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=aab241f28dc1ed01066a71b76a57b61ef43d5111 commit aab241f28dc1ed01066a71b76a57b61ef43d5111 Author: Holger Hans Peter Freyther Date: Tue Jan 22 07:37:41 2013 +0100 sysmobts: We can now pass the trx to the callback change the signatures http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=c9bd31fdd5fc8c85b0e792a06667bf61881bca83 commit c9bd31fdd5fc8c85b0e792a06667bf61881bca83 Author: Holger Hans Peter Freyther Date: Mon Jan 21 14:49:20 2013 +0100 sysmobts: Remove the trx parameter from the signature l1if_gsm_req_compl everyone is passing the trx as data pointer right now, remove it from the request procedure right now as it can be deducted from the femtol1_hdl. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=2a600b751b273a2dd798b0ac1ae8b85a39b06cf6 commit 2a600b751b273a2dd798b0ac1ae8b85a39b06cf6 Author: Holger Hans Peter Freyther Date: Mon Jan 21 14:02:34 2013 +0100 sysmobts: Embed the calib state in the femtol1_hdl and use hdl->priv http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=1163e109dfac7e5de0498a93167758cd7154d167 commit 1163e109dfac7e5de0498a93167758cd7154d167 Author: Holger Hans Peter Freyther Date: Mon Jan 21 12:39:24 2013 +0100 sysmobts: Use the hdl->priv in l1if_req_compl for all callers http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=817c95f80c32f24c4c6a768e83ebd801f62e9cf1 commit 817c95f80c32f24c4c6a768e83ebd801f62e9cf1 Author: Holger Hans Peter Freyther Date: Mon Jan 21 12:27:15 2013 +0100 sysmobts: Remove the data parameter from the l1if_gsm_req_compl Pass in the trx argument at the lower level as everyone is using the fl1h->priv now. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=c7460351dab1a86484700ea395c686981bd7d23d commit c7460351dab1a86484700ea395c686981bd7d23d Author: Holger Hans Peter Freyther Date: Mon Jan 21 12:16:47 2013 +0100 oml: Use the fl1h->priv and get the ts back from the response http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=cf95ad191c42ad5f487d4ad1be411ec0179a83fe commit cf95ad191c42ad5f487d4ad1be411ec0179a83fe Author: Holger Hans Peter Freyther Date: Mon Jan 21 11:25:41 2013 +0100 sysmobts: Use the fl1h->priv to get the trx instead of using the lchan I am working toward killing the last argument of the l1if_gsm_req_compl and just have the trx inside the callback signature. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=d8002eb6c2869612b39f8a8357e7a31665b1bec8 commit d8002eb6c2869612b39f8a8357e7a31665b1bec8 Author: Holger Hans Peter Freyther Date: Wed Jan 16 14:14:36 2013 +0100 DEBUGGING HELP release... WIP... http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=90409c293f484f4032360c7fa5034f2653319861 commit 90409c293f484f4032360c7fa5034f2653319861 Author: Holger Hans Peter Freyther Date: Sun Jan 13 09:47:52 2013 +0100 oml: Use the queue for the release handling of a channel There are three new commands. There are two markers and a deactivate command. The markers are used to wait until all previous commands are executed and then to decide if the SAPI needs to be released at all. When asked to release the SACCH the marker will be queued, then on execution of the marker the SACCH in Up-/Downlink will be released. For the RF Channel Release we use another marker, when the marker is executed we check all the SAPIs we want to release. It is possible that the queue looks like this: (SACCH_REL_MARKER is done) REL_MARKER, SACCH DEACT, SACCH DEACT This could happen if a BSC sends SACCH Deactivate and RF Channel Release at the same time. We deal with issue by changing the SAPI state to the REL_REQ state and check_sapi_release will not ask for another release. So after the execution the queue will look like this: SACCH DEACT, FACCH DEACT, TCHF DEACT.. This code does not check that all allocated SAPIs are released. The lchan_deactivate_sapis could be changed to go through all sapis_dl and sapis_ul to fix that. The normal flow should now be: 1.) lchan_deactivate 2.) Check if the queue is empty then go to 4 3.) REL_MARKER is executed and lchan_deactivate_sapis is called 4.) For all SAPIs to be released, check if they are allocated and then schedule a CMD_DEACTIVATE. If there is an error remember something went wrong but continue. 5.) Once all commands are executed send the channel release ack. For the release markers we need to be careful as they might not schedule any work. E.g. if the BSC sends two SACCH DEACTIVATE the second marker will not generate any release requests and we should proceed with the next command. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=bc7af9522f3733683d7c317bdb4ba94ddbc84343 commit bc7af9522f3733683d7c317bdb4ba94ddbc84343 Author: Daniel Willmann Date: Fri Jan 4 00:14:11 2013 +0100 oml: Print out power setting in txpower completion callback http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=f4010fcd6a0e44d3af972ba5168afe2a809854b8 commit f4010fcd6a0e44d3af972ba5168afe2a809854b8 Author: Daniel Willmann Date: Thu Jan 3 23:35:12 2013 +0100 oml: Use sapi command queue for setting the logical channel params http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=1697cd9bb0a522d9cb084041e0f053dd09194869 commit 1697cd9bb0a522d9cb084041e0f053dd09194869 Author: Daniel Willmann Date: Thu Jan 3 20:55:12 2013 +0100 oml: Enqueue ciphering message through sapi cmd queue as well http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=662f868be19f8ce062422b4e15f37cd671ba42f7 commit 662f868be19f8ce062422b4e15f37cd671ba42f7 Author: Daniel Willmann Date: Thu Jan 3 17:37:59 2013 +0100 oml: Introduce a SAPI queue for activation and deactivation of SAPIs Put all SAPI requests into a queue and handle them one after another. Begin with the channel activation. Once the queue is empty the channel activate will be sent. For the BCCH activation we do not want to send a channel activation message and this is why we set the lchan->state to NONE. One change is that we do not attempt to call the ciphering routines on the BCCH anymore. This change is necessary to fix issues with LCHANs staying open and being marked as broken by the BSC and will help in implementing handover support as this requires a re-configuration of the lchan on the fly. ----------------------------------------------------------------------- Summary of changes: contrib/respawn.sh | 4 +++ include/osmo-bts/bts_model.h | 1 + src/common/bts.c | 4 ++- src/osmo-bts-sysmo/l1_if.c | 2 +- src/osmo-bts-sysmo/oml.c | 8 +++--- tests/cipher/Makefile.am | 2 +- tests/cipher/cipher_test.c | 40 ----------------------------------- tests/paging/Makefile.am | 2 +- tests/paging/paging_test.c | 40 ----------------------------------- tests/stubs.c | 48 ++++++++++++++++++++++++++++++++++++++++++ 10 files changed, 63 insertions(+), 88 deletions(-) create mode 100644 tests/stubs.c hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)