From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Fri, 07 Dec 2012 19:28:55 +0100 Message-ID: Subject: openbsc.git branch zecke/mgcp-transactions created. 0.12.0-166-g98fd5aa Message: 1 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, zecke/mgcp-transactions has been created at 98fd5aa40bc3bec2aeb41debad8a4eb655651018 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/openbsc/commit/?id=98fd5aa40bc3bec2aeb41debad8a4eb655651018 commit 98fd5aa40bc3bec2aeb41debad8a4eb655651018 Author: Holger Hans Peter Freyther Date: Fri Dec 7 15:04:07 2012 +0100 mgcp: Test and implement re-transmission handling MGCP is used over UDP and a response might be lost. The MGCP RFC asks for keeping a list of responses and then using the previous response. I tried to conserve memory and just wanted to remember the last transaction and result and re-generate the result. This made the code look bad and this is why the entire response will now be saved. It sadly increases the memory usage but can not be avoided. Remove the msg->l3h pointer for the RQNT callback as strtok has modified the content of it. http://cgit.osmocom.org/cgit/openbsc/commit/?id=932e386c712955bf51f7750f15239d93459a0214 commit 932e386c712955bf51f7750f15239d93459a0214 Author: Holger Hans Peter Freyther Date: Fri Dec 7 16:07:46 2012 +0100 mgcp: Change the flow of the code when handling a MGCP response Attempt to detect a response and return only then. Remove one level of tabls in preparation for the re-transmission handling. http://cgit.osmocom.org/cgit/openbsc/commit/?id=8403623684a0060c78f848112214987bfa2bad38 commit 8403623684a0060c78f848112214987bfa2bad38 Author: Holger Hans Peter Freyther Date: Fri Dec 7 15:14:27 2012 +0100 mgcp: Methods generating a response now include the endpoint pointer This is required for remembering the last result in a central place and is required to properly implement detection of re-transmissions. http://cgit.osmocom.org/cgit/openbsc/commit/?id=1df880873ac5178948dbe0e087b97f162e6b736f commit 1df880873ac5178948dbe0e087b97f162e6b736f Author: Holger Hans Peter Freyther Date: Fri Dec 7 14:42:03 2012 +0100 mgcp: Test the second CRCX as a CRCX and not as a re-transmission The second CRCX would be mostly ignored and be handled by the retransmission layer of MGCP. http://cgit.osmocom.org/cgit/openbsc/commit/?id=3e1da5a50cbafe0e28b49a1f7dae9653ddb9cc3e commit 3e1da5a50cbafe0e28b49a1f7dae9653ddb9cc3e Author: Holger Hans Peter Freyther Date: Fri Dec 7 16:46:19 2012 +0100 mgcp: Fix a typo.. it is msg and not mgs http://cgit.osmocom.org/cgit/openbsc/commit/?id=622eb4cd42c79b7c56885f460baceddc854721b0 commit 622eb4cd42c79b7c56885f460baceddc854721b0 Author: Holger Hans Peter Freyther Date: Fri Dec 7 11:52:16 2012 +0100 mgcp: We do not need to check for talloc_free Simplify the code and remove null check for the two strings. ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)