From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Wed, 23 Jan 2013 18:29:25 +0100 Message-ID: Subject: osmo-bts.git branch zecke/channel-release updated. 0.1.0-64-g982708c Message: 5 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, zecke/channel-release has been updated discards 5ce1f5066a1b23aa44ac611a699a98762476fc0d (commit) discards fba89171413136f7c84ddbfd54b0cf51ded1df58 (commit) discards 4625c38485edd206730cde21af1e3cab4ca8824a (commit) discards b0a15ca1e7ebef9b2a388545d47f88fae47a2821 (commit) discards 1ecb2ce4855f86d512dfcaa5006bfd1de06c7c40 (commit) discards c4cdb16befca17c49e66141cdd20d995ceb4c130 (commit) discards e979cbde26b724af5c853f6456caf6605d6f5d06 (commit) discards 1389839e423a1374bb5b37943f42c9246e7c0c7a (commit) discards 8bc588f143fd4b1fd1f6d32c968b4982d9086e26 (commit) discards e0b072348443163a35eb9e3d661686b971d01c94 (commit) discards b71040192ada49bf816f7b03ccccd0a43329f162 (commit) discards d98863f9001af14f830650dbf28b172dc7382f7b (commit) discards 1872ec4cd1436ceb7e2820646de41417f9467b9c (commit) discards fd407484196ca72ab02b2a9261a4837c72a4b021 (commit) discards 2cdce76ae8ccdc53d8ac643c10a42c83901d7f30 (commit) discards ee0cd9c288f5a63eae87af8316f2e381a49dc428 (commit) discards 745615909a17003d5329ae15f663f54126aa508e (commit) discards 134d4bcc4af524976221d72873e51d2db74502ae (commit) discards 892e9d867638a51b64a5e14a65f6d9b64a0f0e33 (commit) discards f21cd1db8260da2f71b8776ac01eda56a6435693 (commit) discards e0335db2a14b4e5275d9a4bc28be8f3d1e3c2f49 (commit) discards 6ae997d567e883811351fcecc238482a5018ebdd (commit) via 982708cda1f36871a14b7e036aa944b103e74f96 (commit) via dce43793d0e061dd710e912f721fc31145a8322c (commit) via 7e13242346acc2c3fa9bbb1708a0699551ad1703 (commit) via 3a220297203479f1720d015d747bff40d04d8d0a (commit) via 057d10ff8c74aa658806bd9182a8864df140ac02 (commit) via 228d6e576359e7fc3950c36c84d59c38dd0767bf (commit) via f1ccf838a9118922a159ebbd4db522191c6224f8 (commit) via ee762c1ff006b464ccb673be350c0585e543bc9a (commit) via 4cfe43e82705887db0a289d6538522fd58b441da (commit) via 4b7d1ba5ac8c9d8483bc36b35654338f76b6e5eb (commit) via d8755f5cbe7311cc06a0690edde88a9f3fe9d7ca (commit) via 4c020635be485db202417d3982c31bca07498506 (commit) via ec1a84e5ec3e90aec5949b87e9ccff812a68bb65 (commit) via 4caede7fdd2474cc446a76ac4cfb93fccf95d3e3 (commit) via 84d63242483ed33af696b680ea73abe00dcb8104 (commit) via 0002ca684df9ac53213d47b110125ab7bdddded8 (commit) via 7a0ab3f99580af30dd50777d0888cbcfbbe00423 (commit) via 53a812621ff4eef72b2765a22aaa1d3e7d42b666 (commit) via 949d90659e73b0579dc901e924e27090d4e92d64 (commit) via f0c5a424af1a99d7d03a72eaa1ac6f87ea7b36c1 (commit) via 76a1bf6136ce224b92c4192953d32d1efbebe9bc (commit) via e210f1a864b0752f5baeb14de8ddcfc7320007a4 (commit) via 61e739912f22a4c6e4eca5ed7852bbc0077ba93e (commit) via 4a303c7c38b322e5738a9492e077467bddfd3f38 (commit) via 8597a278d681e687920d62271559e8589781b1e4 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (5ce1f5066a1b23aa44ac611a699a98762476fc0d) \ N -- N -- N (982708cda1f36871a14b7e036aa944b103e74f96) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=982708cda1f36871a14b7e036aa944b103e74f96 commit 982708cda1f36871a14b7e036aa944b103e74f96 Author: Holger Hans Peter Freyther Date: Wed Jan 16 14:14:36 2013 +0100 DEBUGGING HELP release... WIP... http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=dce43793d0e061dd710e912f721fc31145a8322c commit dce43793d0e061dd710e912f721fc31145a8322c Author: Holger Hans Peter Freyther Date: Wed Jan 23 17:36:14 2013 +0100 WIP... try to overcome the short coming http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=7e13242346acc2c3fa9bbb1708a0699551ad1703 commit 7e13242346acc2c3fa9bbb1708a0699551ad1703 Author: Holger Hans Peter Freyther Date: Sun Jan 20 11:35:48 2013 +0100 measurement: Add debug helper when we have a report for an inactive channel http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=3a220297203479f1720d015d747bff40d04d8d0a commit 3a220297203479f1720d015d747bff40d04d8d0a Author: Holger Hans Peter Freyther Date: Tue Jan 22 15:45:14 2013 +0100 sysmobts: Prepare to address the documented limitation of this code http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=057d10ff8c74aa658806bd9182a8864df140ac02 commit 057d10ff8c74aa658806bd9182a8864df140ac02 Author: Holger Hans Peter Freyther Date: Tue Jan 22 15:36:49 2013 +0100 sysmobts: Fix a memory leak when no callback is set The TxPower handled used to call the requestion function without a callback. In that case the msgb is leaked. The code still allows the callback to be NULL so we will just delete the message in that case. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=228d6e576359e7fc3950c36c84d59c38dd0767bf commit 228d6e576359e7fc3950c36c84d59c38dd0767bf Author: Holger Hans Peter Freyther Date: Tue Jan 22 15:22:55 2013 +0100 sysmobts: Remove the is_system_primitive from l1if_req_compl All users (but the gsm_compl) of the l1if_req_compl use it with is_system_primitive=1. We can now remove this parameter from the method. Introduce _l1if_req_compl that will insert the item into the queue for us. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=f1ccf838a9118922a159ebbd4db522191c6224f8 commit f1ccf838a9118922a159ebbd4db522191c6224f8 Author: Holger Hans Peter Freyther Date: Tue Jan 22 07:37:41 2013 +0100 sysmobts: We can now pass the trx to the callback change the signatures http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=ee762c1ff006b464ccb673be350c0585e543bc9a commit ee762c1ff006b464ccb673be350c0585e543bc9a Author: Holger Hans Peter Freyther Date: Mon Jan 21 14:49:20 2013 +0100 sysmobts: Remove the trx parameter from the signature l1if_gsm_req_compl everyone is passing the trx as data pointer right now, remove it from the request procedure right now as it can be deducted from the femtol1_hdl. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=4cfe43e82705887db0a289d6538522fd58b441da commit 4cfe43e82705887db0a289d6538522fd58b441da Author: Holger Hans Peter Freyther Date: Mon Jan 21 14:02:34 2013 +0100 sysmobts: Embed the calib state in the femtol1_hdl and use hdl->priv http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=4b7d1ba5ac8c9d8483bc36b35654338f76b6e5eb commit 4b7d1ba5ac8c9d8483bc36b35654338f76b6e5eb Author: Holger Hans Peter Freyther Date: Mon Jan 21 12:39:24 2013 +0100 sysmobts: Use the hdl->priv in l1if_req_compl for all callers http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=d8755f5cbe7311cc06a0690edde88a9f3fe9d7ca commit d8755f5cbe7311cc06a0690edde88a9f3fe9d7ca Author: Holger Hans Peter Freyther Date: Mon Jan 21 12:27:15 2013 +0100 sysmobts: Remove the data parameter from the l1if_gsm_req_compl Pass in the trx argument at the lower level as everyone is using the fl1h->priv now. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=4c020635be485db202417d3982c31bca07498506 commit 4c020635be485db202417d3982c31bca07498506 Author: Holger Hans Peter Freyther Date: Mon Jan 21 12:16:47 2013 +0100 oml: Use the fl1h->priv and get the ts back from the response http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=ec1a84e5ec3e90aec5949b87e9ccff812a68bb65 commit ec1a84e5ec3e90aec5949b87e9ccff812a68bb65 Author: Holger Hans Peter Freyther Date: Mon Jan 21 11:25:41 2013 +0100 sysmobts: Use the fl1h->priv to get the trx instead of using the lchan I am working toward killing the last argument of the l1if_gsm_req_compl and just have the trx inside the callback signature. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=4caede7fdd2474cc446a76ac4cfb93fccf95d3e3 commit 4caede7fdd2474cc446a76ac4cfb93fccf95d3e3 Author: Holger Hans Peter Freyther Date: Sun Jan 13 09:47:52 2013 +0100 oml: Use the queue for the release handling of a channel There are three new commands. There are two markers and a deactivate command. The markers are used to wait until all previous commands are executed and then to decide if the SAPI needs to be released at all. When asked to release the SACCH the marker will be queued, then on execution of the marker the SACCH in Up-/Downlink will be released. For the RF Channel Release we use another marker, when the marker is executed we check all the SAPIs we want to release. It is possible that the queue looks like this: (SACCH_REL_MARKER is done) REL_MARKER, SACCH DEACT, SACCH DEACT This could happen if a BSC sends SACCH Deactivate and RF Channel Release at the same time. We deal with issue by changing the SAPI state to the REL_REQ state and check_sapi_release will not ask for another release. So after the execution the queue will look like this: SACCH DEACT, FACCH DEACT, TCHF DEACT.. This code does not check that all allocated SAPIs are released. The lchan_deactivate_sapis could be changed to go through all sapis_dl and sapis_ul to fix that. The normal flow should now be: 1.) lchan_deactivate 2.) Check if the queue is empty then go to 4 3.) REL_MARKER is executed and lchan_deactivate_sapis is called 4.) For all SAPIs to be released, check if they are allocated and then schedule a CMD_DEACTIVATE. If there is an error remember something went wrong but continue. 5.) Once all commands are executed send the channel release ack. For the release markers we need to be careful as they might not schedule any work. E.g. if the BSC sends two SACCH DEACTIVATE the second marker will not generate any release requests and we should proceed with the next command. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=84d63242483ed33af696b680ea73abe00dcb8104 commit 84d63242483ed33af696b680ea73abe00dcb8104 Author: Daniel Willmann Date: Fri Jan 4 00:14:11 2013 +0100 oml: Print out power setting in txpower completion callback http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=0002ca684df9ac53213d47b110125ab7bdddded8 commit 0002ca684df9ac53213d47b110125ab7bdddded8 Author: Daniel Willmann Date: Thu Jan 3 23:35:12 2013 +0100 oml: Use sapi command queue for setting the logical channel params http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=7a0ab3f99580af30dd50777d0888cbcfbbe00423 commit 7a0ab3f99580af30dd50777d0888cbcfbbe00423 Author: Daniel Willmann Date: Thu Jan 3 20:55:12 2013 +0100 oml: Enqueue ciphering message through sapi cmd queue as well http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=53a812621ff4eef72b2765a22aaa1d3e7d42b666 commit 53a812621ff4eef72b2765a22aaa1d3e7d42b666 Author: Daniel Willmann Date: Thu Jan 3 17:37:59 2013 +0100 oml: Introduce a SAPI queue for activation and deactivation of SAPIs Put all SAPI requests into a queue and handle them one after another. Begin with the channel activation. Once the queue is empty the channel activate will be sent. For the BCCH activation we do not want to send a channel activation message and this is why we set the lchan->state to NONE. One change is that we do not attempt to call the ciphering routines on the BCCH anymore. This change is necessary to fix issues with LCHANs staying open and being marked as broken by the BSC and will help in implementing handover support as this requires a re-configuration of the lchan on the fly. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=949d90659e73b0579dc901e924e27090d4e92d64 commit 949d90659e73b0579dc901e924e27090d4e92d64 Author: Daniel Willmann Date: Thu Jan 3 17:49:49 2013 +0100 oml: Put sending into it's own function mph_send_activate_req ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-sysmo/calib_file.c | 7 ++--- src/osmo-bts-sysmo/l1_if.c | 58 +++++++++++++++++++++++++------------- src/osmo-bts-sysmo/l1_if.h | 4 +- src/osmo-bts-sysmo/oml.c | 50 ++++++++++++++++++++------------- 4 files changed, 73 insertions(+), 46 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)