From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Fri, 12 Sep 2014 13:15:32 GMT Message-ID: <201409121315.s8CDFWDQ062924@git.osmocom.org> Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-648-g650bda3 Message: 2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 3f5ff5b464fd7535a668c063a22f62d56795fd54 (commit) via 650bda37b2fb80bc1246c826143aacb746f4d2c8 (commit) via 4f5c21e121bc751dc67b9b04bb2788c2c0a82f62 (commit) via dcb4ffb0561d97b356ce61a61e2cee94a8386a8c (commit) via c60f074facb1118c2cbfbba93368f09734caf859 (commit) via 3f21c08fbea2063e7aa9825139da5f63709149fd (commit) via 8564fb9d244c97b36e55dd1ba33693a5689d71bf (commit) via 34c008de6b169b7426096f4cd949e4616849037d (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (3f5ff5b464fd7535a668c063a22f62d56795fd54) \ N -- N -- N (650bda37b2fb80bc1246c826143aacb746f4d2c8) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=650bda37b2fb80bc1246c826143aacb746f4d2c8 commit 650bda37b2fb80bc1246c826143aacb746f4d2c8 Author: Jacob Erlbeck Date: Fri Sep 12 15:09:56 2014 +0200 gbproxy: Keep tlli_info after detach (TODO) TODO: - VTY - commit message - testing - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4f5c21e121bc751dc67b9b04bb2788c2c0a82f62 commit 4f5c21e121bc751dc67b9b04bb2788c2c0a82f62 Author: Jacob Erlbeck Date: Fri Sep 12 14:15:02 2014 +0200 gbproxy: Remove gbproxy_register_tlli This function is a remainder of the initial implemenation that was not meant for TLLI patching and can be used for the BSS side only. The SGSN side is already using a composition of more flexible single purpose functions. This patch changes the implementation to use a similar approach. The function is moved to gbproxy_test.c and renamed to register_tlli to keep the tests intact. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=dcb4ffb0561d97b356ce61a61e2cee94a8386a8c commit dcb4ffb0561d97b356ce61a61e2cee94a8386a8c Author: Jacob Erlbeck Date: Thu Sep 11 14:20:53 2014 +0200 sgsn: Reset local LLC parameters when sending XID reset Currently when gprs_llgmm_reset() is invoked an XID reset is sent but the local LLC parameters (e.g. V(U)) are not cleared (see GSM 04.64, 8.5.3.1). This can lead to discarded messages on the SGSN side. This patch modifies gprs_llgmm_reset to clear vu_send, vu_recv, oc_ui_send, oc_ui_recv. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c60f074facb1118c2cbfbba93368f09734caf859 commit c60f074facb1118c2cbfbba93368f09734caf859 Author: Jacob Erlbeck Date: Fri Sep 5 14:32:36 2014 +0200 sgsn: Send detach(re-attach) instead of gmm status if TLLI unknown (TODO) The osmo-sgsn sends Status messages (or nothing in case of non GMM/GSM) when the TLLI is unknown. This prevents the MS from reconnecting. This experimental patch initiates a MT detach procedure to force a re-attach to set up a valid LLE context. TODO: - commit message - handle MO detach req (perhaps just send a faked ACK then) - test cases Note that the MS can be put into REGISTERED state after initially wanting to detach itself, since it will receive a Detach Req (re-attach). This same behaviour has been observed with another SGSN. Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3f21c08fbea2063e7aa9825139da5f63709149fd commit 3f21c08fbea2063e7aa9825139da5f63709149fd Author: Jacob Erlbeck Date: Fri Sep 12 12:12:31 2014 +0200 gbproxy: Send DETACH_ACC if the IMSI has not been acquired If IMSI acquisition is enabled and the gbproxy receives a Detach request from the MS, it cannot pass it to the SGSN since the acquisition has not yet been completed. This patch implements the generation of a Detach Accept message and for this case and updates the TLLI state accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8564fb9d244c97b36e55dd1ba33693a5689d71bf commit 8564fb9d244c97b36e55dd1ba33693a5689d71bf Author: Jacob Erlbeck Date: Thu Sep 11 15:22:18 2014 +0200 gbproxy: Fixed RAI patching in Attach Request messages Currently the RAI in the LLC part of the message is not updated if the message has been taken from the list of stored messages. The reason is, that old_raid_matches is update in gbprox_process_bssgp_ul() but not in gbproxy_flush_stored_messages(). This patch moves the check to gprs_gb_parse_bssgp() which is called at both places and where other fields like parse_ctx->tlli are set, too. In addition, old_raid_matches is replaced by old_raid_differs since this is clearer in the case when there is no old RAI at all. Several RAI patch counter assertions are also added to test_gbproxy_ra_patching(). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=34c008de6b169b7426096f4cd949e4616849037d commit 34c008de6b169b7426096f4cd949e4616849037d Author: Jacob Erlbeck Date: Fri Sep 12 10:33:38 2014 +0200 gbproxy/test: Add/modify test cases Add a Attach Request message to test_gbproxy_ra_patching, where the BSSGP RAI differs from the old RAI signalled in the LLC part. This case had not been tested explicitely yet. Change the RAI in the first Attach Request in test_gbproxy_imsi_acquisition from rai_unknown to rai_bss. Add Detach Requests to test_gbproxy_imsi_acquisition, one for a incomplete attach procedure and one for an unknown (fresh) TLLI. In these cases, the acquisition of a IMSI is not necessary and also doesn't work properly with an E71. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gb_proxy.h | 13 ++- openbsc/include/openbsc/gprs_gmm.h | 2 + openbsc/include/openbsc/gprs_llc.h | 1 + openbsc/include/openbsc/gsm_04_08_gprs.h | 1 + openbsc/src/gprs/gb_proxy.c | 70 ++++++++++++--- openbsc/src/gprs/gb_proxy_tlli.c | 128 ++++++++++++---------------- openbsc/src/gprs/gprs_gb_parse.c | 4 + openbsc/src/gprs/gprs_gmm.c | 92 +++++++++++++++++++- openbsc/src/gprs/gprs_llc.c | 40 ++++++++- openbsc/tests/gbproxy/gbproxy_test.c | 142 ++++++++++++++++++++++++++++--- openbsc/tests/gbproxy/gbproxy_test.ok | 122 +++++++++++++++++--------- 11 files changed, 470 insertions(+), 145 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)