From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Tue, 21 Oct 2014 08:03:28 GMT Message-ID: <201410210803.s9L83SxA003315@git.osmocom.org> Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-720-g23bba4b Message: 3 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 914e48067104c3bf474edcbc6af0a6b9e87c0a4a (commit) discards 9f70ec6c8e0b3a8c41da087e316277f8d1e45cdc (commit) discards 9114a3459fb74a1be1bb29ca8b546d3cb606ccc7 (commit) discards 87b49f73e9d47aa9a023df154af3ba601a8286f9 (commit) discards abf4991f1c79301718cda7293af315759bf02c09 (commit) discards d045965226e234fc3d5b019030dd29bc9a096154 (commit) discards 7fba9e80d97c14658cadca76a6783110b07d0ded (commit) via 23bba4b9414bc5ae5b1225edb79717692fb947c2 (commit) via 9c1c1db35d7ec12459f01e01d9d4ed11ad49ee34 (commit) via c33b074085daa83fa88202beb50fecdfd96396c3 (commit) via a29672811bb2134721fa9ba8d7310d7d86692b53 (commit) via 7d30d856505310b8b341a1cf391910ec47e62b20 (commit) via 9b83b07e57fe96886610e1b5e4dacdfbd52cbb7e (commit) via 5d9757c108ec1eb2765f4baccbfa50f8652a7511 (commit) via 1ec30a328c83210ba1b18f5d5f7189b0b4363650 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (914e48067104c3bf474edcbc6af0a6b9e87c0a4a) \ N -- N -- N (23bba4b9414bc5ae5b1225edb79717692fb947c2) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=23bba4b9414bc5ae5b1225edb79717692fb947c2 commit 23bba4b9414bc5ae5b1225edb79717692fb947c2 Author: Jacob Erlbeck Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(power_off) - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Fix P-TMSI generation for repeated Attach Accept messages (OW#1322) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9c1c1db35d7ec12459f01e01d9d4ed11ad49ee34 commit 9c1c1db35d7ec12459f01e01d9d4ed11ad49ee34 Author: Jacob Erlbeck Date: Tue Oct 21 09:52:05 2014 +0200 sgsn: Only send Detach Accept (MO) if power_off isn't set (TODO) Currently, every time the SGSN received a Detach Request from the MS via an established logical link, it is answered by a Detach Accept. This violates the specification (GSM 04.08, 4.7.4.1.2 and .3), which states, that it should only be sent, if "the detach type IE value indicates that the detach request has not been sent due to switching off". This patch adds a conditional to limit the sending of Detach Accept accordingly. TODO: - add test Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c33b074085daa83fa88202beb50fecdfd96396c3 commit c33b074085daa83fa88202beb50fecdfd96396c3 Author: Jacob Erlbeck Date: Tue Sep 30 13:49:43 2014 +0200 gbproxy: Patch BSSGP P-TMSI in PAGING PS messages (TODO) Currently the P-TMSI IE in PAGING_PS is not patched. This commit adds code the patch BSSGP P-TMSI IE in gbproxy_patch_bssgp independently from the P-TMSI patching at the LLC layer. TODO: - finish test case Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a29672811bb2134721fa9ba8d7310d7d86692b53 commit a29672811bb2134721fa9ba8d7310d7d86692b53 Author: Jacob Erlbeck Date: Mon Oct 20 17:22:36 2014 +0200 gbproxy: Fix segfault for VTY delete-gbproxy-link Currently the code segfaults when the link shall be deleted by IMSI when the IMSI has not been set yet. This patch adds a NULL check to skip the entry before calling gsm48_mi_to_string, Adresses: Program received signal SIGSEGV, Segmentation fault. 0xb693af77 in gsm48_mi_to_string (string=0xbfffe020 "", str_len=200, mi=0x0, mi_len=0) at gsm48.c:360 360 mi_type = mi[0] & GSM_MI_TYPE_MASK; str_len=200, mi=0x0, mi_len=0) at gsm48.c:360 self=0x807c9a0 , vty=0xb4303c70, argc=3, argv=0xbfffe1c0) at gb_proxy_vty.c:670 ... Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7d30d856505310b8b341a1cf391910ec47e62b20 commit 7d30d856505310b8b341a1cf391910ec47e62b20 Author: Jacob Erlbeck Date: Mon Oct 20 16:30:06 2014 +0200 gbproxy: Fix P-TMSI generation for repeated Attach Accept messages Currently, when P-TMSI patching is enabled, a new BSS P-TMSI is generated for each Attach Accept. So two duplicated, subsequent Attach Accept messages will be mapped to different BSS side P-TMSI. Because the last one will replace former ones in the link_info struct, the MS will fail to access the SGSN if it uses the former P-TMSI to derive the new TLLI. This patch checks the SGSN P-TMSI already assigned to the link_info and only generates a new BSS P-TMSI on mismatch (or if the BSS P-TMSI hasn't been set yet). Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9b83b07e57fe96886610e1b5e4dacdfbd52cbb7e commit 9b83b07e57fe96886610e1b5e4dacdfbd52cbb7e Author: Jacob Erlbeck Date: Mon Oct 20 16:25:01 2014 +0200 gbproxy/test: Add test case for repeated and otherwise bad messages This adds a test case to check gbproxy's behaviour when processing two subsequent but identical Attach Accept messages. Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5d9757c108ec1eb2765f4baccbfa50f8652a7511 commit 5d9757c108ec1eb2765f4baccbfa50f8652a7511 Author: Jacob Erlbeck Date: Mon Oct 20 16:05:55 2014 +0200 sgsn: Cancel pending timer in sgsn_mm_ctx_free Currently the timer is not stopped before the MM context is freed which can lead to failure if sgsn_mm_ctx_free is called while timer protected procedures are active. This patch add code to cancel the timer if necessary from within sgsn_mm_ctx_free. Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1ec30a328c83210ba1b18f5d5f7189b0b4363650 commit 1ec30a328c83210ba1b18f5d5f7189b0b4363650 Author: Jacob Erlbeck Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_gmm.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)