From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Mon, 20 Oct 2014 15:29:39 GMT Message-ID: <201410201529.s9KFTdYh017026@git.osmocom.org> Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-719-g914e480 Message: 2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated via 914e48067104c3bf474edcbc6af0a6b9e87c0a4a (commit) via 9f70ec6c8e0b3a8c41da087e316277f8d1e45cdc (commit) via 9114a3459fb74a1be1bb29ca8b546d3cb606ccc7 (commit) via 87b49f73e9d47aa9a023df154af3ba601a8286f9 (commit) from abf4991f1c79301718cda7293af315759bf02c09 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=914e48067104c3bf474edcbc6af0a6b9e87c0a4a commit 914e48067104c3bf474edcbc6af0a6b9e87c0a4a Author: Jacob Erlbeck Date: Mon Oct 20 17:22:36 2014 +0200 gbproxy: Fix segfault for VTY delete-gbproxy-link Currently the code segfaults when the link shall be deleted by IMSI when the IMSI has not been set yet. This patch adds a NULL check to skip the entry before calling gsm48_mi_to_string, Adresses: Program received signal SIGSEGV, Segmentation fault. 0xb693af77 in gsm48_mi_to_string (string=0xbfffe020 "", str_len=200, mi=0x0, mi_len=0) at gsm48.c:360 360 mi_type = mi[0] & GSM_MI_TYPE_MASK; str_len=200, mi=0x0, mi_len=0) at gsm48.c:360 self=0x807c9a0 , vty=0xb4303c70, argc=3, argv=0xbfffe1c0) at gb_proxy_vty.c:670 ... Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9f70ec6c8e0b3a8c41da087e316277f8d1e45cdc commit 9f70ec6c8e0b3a8c41da087e316277f8d1e45cdc Author: Jacob Erlbeck Date: Mon Oct 20 16:30:06 2014 +0200 gbproxy: Fix P-TMSI generation for repead Attach Accept messages Currently, when P-TMSI patching is enabled, a new BSS P-TMSI is generated for each Attach Accept. So two duplicated, subsequent Attach Accept messages will be mapped to different BSS side P-TMSI. Because the last one will replace former ones in the link_info struct, the MS will fail to access the SGSN if it uses the former P-TMSI to derive the new TLLI. This patch checks the SGSN P-TMSI already assigned to the link_info and only generates a new BSS P-TMSI on mismatch (or if the BSS P-TMSI hasn't been set yet). Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9114a3459fb74a1be1bb29ca8b546d3cb606ccc7 commit 9114a3459fb74a1be1bb29ca8b546d3cb606ccc7 Author: Jacob Erlbeck Date: Mon Oct 20 16:25:01 2014 +0200 gbproxy/test: Add test case for repeated and otherwise bad messages This adds a test case to check gbproxy's behaviour when processing two subsequent but identical Attach Accept messages. Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=87b49f73e9d47aa9a023df154af3ba601a8286f9 commit 87b49f73e9d47aa9a023df154af3ba601a8286f9 Author: Jacob Erlbeck Date: Mon Oct 20 16:05:55 2014 +0200 sgsn: Cancel pending timer in sgsn_mm_ctx_free Currently the timer is not stopped before the MM context is freed which can lead to failure if sgsn_mm_ctx_free is called while timer protected procedures are active. This patch add code to cancel the timer if necessary from within sgsn_mm_ctx_free. Ticket: OW#1322 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gb_proxy_tlli.c | 9 +- openbsc/src/gprs/gb_proxy_vty.c | 2 + openbsc/src/gprs/gprs_sgsn.c | 5 + openbsc/tests/gbproxy/gbproxy_test.c | 181 ++++++++++++++++++++ openbsc/tests/gbproxy/gbproxy_test.ok | 314 ++++++++++++++++++++++++++++++++++ 5 files changed, 509 insertions(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)