From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Thu, 19 Apr 2012 09:51:20 +0200 Message-ID: Subject: branch master updated. 0.0.1-72-gbf91f06 Message: 9 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via bf91f06ecaffe311c821c705c98fd3287f343e34 (commit) via b0150b7ad4610307308595d3fe1b28b31466e8de (commit) via d7718280c98cdd9a6da27fbbf90c171f49969279 (commit) via 1e2b3259b92de9885c882cd0291452d8b7ffbfed (commit) via 29e1fdd994e2ea8c8e7518cb1b979bb23ae23c8a (commit) via af02387183acd5cd80d3183862c8a6a2ed8318d1 (commit) via f78f35880f65fc1aa9dc508465260cdd9d815514 (commit) via eac221b4eae31e5a877040dbe219a8905de393dd (commit) via f4f69ee6fc19b9f8d4d0af615e752cb88b96eae7 (commit) via f1052b812deb55f9645ae2b7cdf1fa7313599c28 (commit) via 0be33e3add129843ae1c519477e5904b0330f315 (commit) from b03f8ae4f05b16997c3db5ed9454672a0d18e679 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=bf91f06ecaffe311c821c705c98fd3287f343e34 commit bf91f06ecaffe311c821c705c98fd3287f343e34 Author: Harald Welte Date: Thu Apr 19 09:50:02 2012 +0200 Improve logging of L1 MPH request by printing the direction where previously we would only see <0006> oml.c:931 (bts=0,trx=0,ts=1,ss=0) MPH-DEACTIVATE.req (FACCH/F) we now get <0006> oml.c:931 (bts=0,trx=0,ts=1,ss=0) MPH-DEACTIVATE.req (FACCH/F RxUL) to notice it is modifying the receive path in the uplink direction. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=b0150b7ad4610307308595d3fe1b28b31466e8de commit b0150b7ad4610307308595d3fe1b28b31466e8de Author: Holger Hans Peter Freyther Date: Mon Apr 16 22:15:29 2012 +0200 lchan: Refuse to activate a non-idle lchan. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=d7718280c98cdd9a6da27fbbf90c171f49969279 commit d7718280c98cdd9a6da27fbbf90c171f49969279 Author: Holger Hans Peter Freyther Date: Mon Apr 16 23:09:18 2012 +0200 lchan: Send the ACT ACK/NACK after the Layer1 has handled act/deact Send the RSL ACT ACK/NACK after the Layer1 firmware has acked the activation/deactivation. In case the channel can not be activated we will send a NACK. In case the channel can not be deactivated we will send an ACK and the next time the channel is activated we will send a NACK. The release ack will be sent once the TxDownlink of the TCH/SDCCH is closed. Change the rsl_tx_chan_nack method to create a new msgb to be used by the hardware layer, change the return value to ask the caller to delete the msgb. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=1e2b3259b92de9885c882cd0291452d8b7ffbfed commit 1e2b3259b92de9885c882cd0291452d8b7ffbfed Author: Holger Hans Peter Freyther Date: Tue Apr 17 22:06:45 2012 +0200 lchan: Separate the Uplink/Downlink in activate/deactivate http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=29e1fdd994e2ea8c8e7518cb1b979bb23ae23c8a commit 29e1fdd994e2ea8c8e7518cb1b979bb23ae23c8a Author: Holger Hans Peter Freyther Date: Wed Apr 18 19:31:42 2012 +0200 lchan: Deactivate the SACCH only once, use the sach_deact flag for that Use the deact_sach (renamed to deact_sacch in master) to remember if the SACCH has been disabled. This should fix the case of lchan errors due releasing the lchan twice. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=af02387183acd5cd80d3183862c8a6a2ed8318d1 commit af02387183acd5cd80d3183862c8a6a2ed8318d1 Author: Holger Hans Peter Freyther Date: Mon Apr 16 21:46:19 2012 +0200 lchan: rsl_tx_chan_nack will re-use the msgb, do not msgb_free Do not msgb_free the msg as it will be re-used inside the nack method and return 1 so the caller does not free the msgb. This ownership model needs some consideration but the usage of ref counts will not yield good results. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=f78f35880f65fc1aa9dc508465260cdd9d815514 commit f78f35880f65fc1aa9dc508465260cdd9d815514 Author: Holger Hans Peter Freyther Date: Mon Apr 16 21:37:10 2012 +0200 lchan: Fix crashes when the specified lchan can not be found gsm_lchan_name will crash if the lchan is NULL. Introduce an error_report method that will do the right thing in the future and report the error. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=eac221b4eae31e5a877040dbe219a8905de393dd commit eac221b4eae31e5a877040dbe219a8905de393dd Author: Holger Hans Peter Freyther Date: Mon Apr 16 20:14:38 2012 +0200 lchan: Fix the state transition in the deactivate handler If the deactivation is failing the channel needs to be moved into and error state, if the deactivation completed the channel needs to be set to the none state and set the state to release reqeust on the deactivation. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=f4f69ee6fc19b9f8d4d0af615e752cb88b96eae7 commit f4f69ee6fc19b9f8d4d0af615e752cb88b96eae7 Author: Holger Hans Peter Freyther Date: Mon Apr 16 20:07:56 2012 +0200 lchan: Similar to OpenBSC use a set method to change the state By making all modifications through lchan_set_state we can easily add code to verify the state transition. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=f1052b812deb55f9645ae2b7cdf1fa7313599c28 commit f1052b812deb55f9645ae2b7cdf1fa7313599c28 Author: Holger Hans Peter Freyther Date: Mon Apr 16 19:10:44 2012 +0200 sysmobts: Add an option to query the hardware version. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=0be33e3add129843ae1c519477e5904b0330f315 commit 0be33e3add129843ae1c519477e5904b0330f315 Author: Holger Hans Peter Freyther Date: Mon Apr 16 18:49:11 2012 +0200 common: Add the copyright text to the vty_app_info This will make app -V print the copyright information like the other applications of our universe. An BTS integration that want to list additionaly copyright holders needs to access the vty_app_info and create a new copyright string. ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/gsm_data.h | 3 + include/osmo-bts/rsl.h | 1 + src/common/Makefile.am | 2 +- src/common/lchan.c | 27 ++++++++++++ src/common/rsl.c | 50 +++++++++++++++------ src/common/vty.c | 13 +++--- src/osmo-bts-sysmo/femtobts.c | 9 ++++ src/osmo-bts-sysmo/femtobts.h | 2 + src/osmo-bts-sysmo/main.c | 18 +++++++- src/osmo-bts-sysmo/oml.c | 95 ++++++++++++++++++++++++++++------------ 10 files changed, 168 insertions(+), 52 deletions(-) create mode 100644 src/common/lchan.c hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)