From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Fri, 5 Sep 2014 12:16:49 GMT Message-ID: <201409051216.s85CGnei020902@git.osmocom.org> Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-635-g5fa2670 Message: 2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards a7a96e5d0bd63149ab3dad3b8eac0ec3dfd2c9b0 (commit) discards e19cb0efa4663b4068d0e5a6f9bb298e85eda1b1 (commit) discards 72f802503ea199db9306c45bc3695620b0e79f05 (commit) discards 0a5b3b74e950f62237aeca2ca6d3ec07482d369b (commit) discards c956fef4664d837e046563ecb1a8096310fae2f2 (commit) discards efe8f8507b20732bef9ca40df9a5adc287de2042 (commit) discards 0ca7900c2b763030cb3699cfea6ff6697b6a1332 (commit) discards 4c1826cf4d651c59cb512bfc82f59a1f62a2538a (commit) discards bbc145d4b5c33d47d853e903bcb4e5bfc974bde9 (commit) discards 7b03e076aafa8f3fc2cf91ffc3e39242842b7154 (commit) discards 0b82f7b6d7545d15c765391f94de0ff100b59291 (commit) discards 6098092b57d64b23c2e46262d209d7dc84aad1bb (commit) discards 1a50569281b783aaeb1f598a5b7a0deb6067b864 (commit) discards 5592fc1affacbe895eeb012c586f4caad8a6094e (commit) discards a94c81fe6d0029cabee1d35207b56a35c7a2f521 (commit) discards e3232203cb57822be29ac2f6c29bc9910dfccd04 (commit) discards c25271bee3ef8d2add943cf0d757a9b54d2c9ebd (commit) discards 9ac537228d323be372698831015f6a0b1a7847fa (commit) via 5fa26701657f79375ae5fad1c845ed3e92204331 (commit) via 70fc07c7c9c3f5ae4957a7645758cedd5d2ef80c (commit) via c8ec12a760ffcdc4f38efb479d62d49dae75e5ea (commit) via b2add813976735fddb032752a9ccb19e2997d31b (commit) via 55ff3af1db3dc59e4fd2d935c076e0df73e85c3f (commit) via 3e301123769dadd8e3a33f09526c2e7f2df38874 (commit) via 80b6ba21a0bc012340ef1a24cc8783eb4e49270b (commit) via 263a3d3d458d3d95726717ee892bf9476fff2bc5 (commit) via 7fbdfa07c4011249cc5bbfcb96a6b821ba972d1e (commit) via ddb9ba7989c236370e781628403fbd226b479fee (commit) via 28bd75d8b62d37ac15a7b2c8ee409f6863d3ad81 (commit) via 0de34998e60325651ca4854b2932b4ea3997d80d (commit) via 6e1d347d13915adb0380f1dee8d6558aae12783d (commit) via 48809ba74554b33b0250a9dac4f84b4f705e28a0 (commit) via 0086bb8d3a2c23d9c23ecbd2e8cc95e2524aa56a (commit) via 5b35d53fcbb29d0048bbde408add63cb9a56c89e (commit) via db96465cce031aca162ffad81033fa6d3443f150 (commit) via 5ce228b002f906f8a076ebddfa72831eb95c2104 (commit) via 0169971a59e9822c094e82f3e4a28f2763ea0f34 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (a7a96e5d0bd63149ab3dad3b8eac0ec3dfd2c9b0) \ N -- N -- N (5fa26701657f79375ae5fad1c845ed3e92204331) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=5fa26701657f79375ae5fad1c845ed3e92204331 commit 5fa26701657f79375ae5fad1c845ed3e92204331 Author: Jacob Erlbeck Date: Thu Sep 4 11:42:08 2014 +0200 gbproxy: Remove patch_mode, update initial checks This patch removes the patch_mode feature including the related VTY command patch-mode. Where sensible, the other configuration flags are queried instead. In addition, this initial checks in gbprox_process_bssgp_dl() and gbprox_process_bssgp_ul() have been updated. The patch mode feature has not been used and was increasingly difficult to maintain. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=70fc07c7c9c3f5ae4957a7645758cedd5d2ef80c commit 70fc07c7c9c3f5ae4957a7645758cedd5d2ef80c Author: Jacob Erlbeck Date: Thu Sep 4 11:08:50 2014 +0200 gbproxy/test: Add assertions, improve test coverage This patch add explicit tests for - gbproxy_peer_by_bvci - gbproxy_peer_by_nsei - gbproxy_cleanup_peers - gbproxy_peer_by_rai - gbproxy_peer_by_lai - gbproxy_peer_by_lac and for messages with an unknown TLLI sent by the SGSN. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c8ec12a760ffcdc4f38efb479d62d49dae75e5ea commit c8ec12a760ffcdc4f38efb479d62d49dae75e5ea Author: Jacob Erlbeck Date: Wed Sep 3 11:59:48 2014 +0200 gbproxy: Reset IMSI acquisition and free stored messages in tlli_info Currently the stored messages are only removed, when IMSI acquisition has succeeded. In addition, receiving two ATTACH_REQ messages in sequence (e.g. due to loss of a Identity Req/Resp message) will not restart the IMSI acquisition procedure. This patch adds gbproxy_tlli_info_discard_messages() to clean up the message list and calls it from gbproxy_delete_tlli() fixing a potential memory leak. It is also called when an Attach Request message has been received. In that case the imsi_acq_pending flag is cleared, too. This would (re-)trigger the IMSI acquisition procedure at each of these messages. If an Ident Response has been lost, resending the Ident Request with the same N(U) will not work. Therefore the N(U) gets incremented on each Ident Request generated by the gbproxy. The first N(U) used is 256 which shouldn't collide with the V(UT) used by the SGSN given that P-TMSI patching is enabled (since a new random TLLI is used initially on every new (no tlli_info) connection and V(U) starts with zero then). Ticket: OW#1261 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b2add813976735fddb032752a9ccb19e2997d31b commit b2add813976735fddb032752a9ccb19e2997d31b Author: Jacob Erlbeck Date: Tue Sep 2 14:40:11 2014 +0200 gbproxy/test: Add test cases for IMSI acquisition If the Attach Request procedure gets restarted e.g. because of a lost message, all of these messages are stored if IMSI acquisition is in progress. This patch adds a test for this case and modifies the dump_peers function to output the number of stored messages. Note that the number of stored messages currently increases with each of the messages mentioned above which is not the desired behaviour. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=55ff3af1db3dc59e4fd2d935c076e0df73e85c3f commit 55ff3af1db3dc59e4fd2d935c076e0df73e85c3f Author: Jacob Erlbeck Date: Thu Sep 4 14:53:30 2014 +0200 gbproxy: Fix P-TMSI reassignment Currently, a new P-TMSI within an Attach Accept or within an RA Update Request is applied to the TLLI mapping (gbproxy_reassign_tlli) _before_ patching is done. This can lead to inconsistent behaviour when the TLLI validation has not been completed, which is the case when subsequent RA UDP REQ are received. The new TLLI must not be applied to the message itself yet, it should only be considered for following messages. This patch moves the TLLI reassignment to gbproxy_update_tlli_state_after() to fix that. It also separates the implementation of the feature, that a new tlli_info can be created when such a message is received from the SGSN. This makes sense, when P-TMSI patching is not active and the tlli_info entry has expired. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3e301123769dadd8e3a33f09526c2e7f2df38874 commit 3e301123769dadd8e3a33f09526c2e7f2df38874 Author: Jacob Erlbeck Date: Fri Sep 5 10:22:27 2014 +0200 gbproxy: Change creation of tlli_info for SGSN originated messages Currently tlli_info are created for SGSN originated messages when the SGSN TLLI cannot be found and P-TMSI patching is active. This doesn't make much sense, since the BSS side TLLI is not known in this case. Given that the SGSN is working properly, that can only happen if either the tlli_info has expired or the gbproxy has been restarted. This patch disables tlli_info creation in this case . Note that these messages are passed unmodified to the MS so far. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=80b6ba21a0bc012340ef1a24cc8783eb4e49270b commit 80b6ba21a0bc012340ef1a24cc8783eb4e49270b Author: Jacob Erlbeck Date: Thu Sep 4 13:45:56 2014 +0200 gbproxy/test: Extend P-TMSI patch test by a sequence of RA UDP REQ This adds a sequence of two RA update procedures to test_gbproxy_ptmsi_patching(). Each of them assigns a new P-TMSI. Note that the implementation fails to patch the RAI within the second message and does not fully verify the 3rd P-TMSI on reception of the SUSPEND ACK. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=263a3d3d458d3d95726717ee892bf9476fff2bc5 commit 263a3d3d458d3d95726717ee892bf9476fff2bc5 Author: Jacob Erlbeck Date: Tue Sep 2 13:57:19 2014 +0200 gbproxy: Reorganize VTY commands Since the secondary SGSN selection and APN patching can both be enable/disabled by IMSI matching, this patch introduces a separate match-imsi command and removes the corresponding variant of the core-access-point-name command. P-TMSI patching and IMSI acquisition are will be enabled/disabled by match-imsi resp. secondary-sgsn. The patch-ptmsi and acquire-imsi commands are still available but are subject to being removed. The gbproxy_check_tlli() function is modified to use a tlli_info pointer instead of a numeric TLLI to test, whether patching is allowed. It is now used instead of accessing tlli_info->enable_patching directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7fbdfa07c4011249cc5bbfcb96a6b821ba972d1e commit 7fbdfa07c4011249cc5bbfcb96a6b821ba972d1e Author: Jacob Erlbeck Date: Tue Sep 2 14:09:01 2014 +0200 gbproxy: Show number of stored messages in VTY show This patch extends the 'show gbproxy tllis' command to display the number of stored messages per tlli_info if there are any. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ddb9ba7989c236370e781628403fbd226b479fee commit ddb9ba7989c236370e781628403fbd226b479fee Author: Jacob Erlbeck Date: Fri Aug 29 13:32:17 2014 +0200 gbproxy: Forward SGSN originated STATUS messages with BVCI Currently all STATUS messages coming from the SGSN are just logged and dropped. This prevents the PCU from recognising that the (secondary) SGSN doesn't know about a certain BVCI and might require a reset procedure. This patch changes gbprox_rx_sig_from_bss() to forward STATUS messages with cause "Invalid BVCI" containing a BVCI to the BSS. Note that this will not forward broken "Invalid BVCI" messages which do not include a BVCI IE. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=28bd75d8b62d37ac15a7b2c8ee409f6863d3ad81 commit 28bd75d8b62d37ac15a7b2c8ee409f6863d3ad81 Author: Jacob Erlbeck Date: Fri Aug 29 12:20:15 2014 +0200 gbproxy: Make STATUS messages spec compliant Currently the gbproxy sends STATUS messages that are not compliant to GSM 08.18, 10.4.14.1: The BVCI must be included if (and only if) the cause is either "BVCI blocked" or "BVCI unknown". This patch adds a missing BVCI to UNKNOWN_BVCI and BVCI_BLOCKED status messages if the BVCI is available. Otherwise, INV_MAND_INF is used instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0de34998e60325651ca4854b2932b4ea3997d80d commit 0de34998e60325651ca4854b2932b4ea3997d80d Author: Jacob Erlbeck Date: Thu Aug 28 13:49:13 2014 +0200 gbproxy: Fix parse_ctx->tlli update Only update parse_ctx->tlli when the TLLI has been patched if sent towards the BSS, so that this field always refers to the the BSS namespace. This fixes the APN patching that doesn't work currently when P-TMSI patching is enabled. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6e1d347d13915adb0380f1dee8d6558aae12783d commit 6e1d347d13915adb0380f1dee8d6558aae12783d Author: Jacob Erlbeck Date: Thu Aug 28 13:47:53 2014 +0200 gbproxy: Add missing commands to VTY write Currently the new command acquire-imsi and secondary-sgsn are not included into the write command's output. This is fixed by this commit. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=48809ba74554b33b0250a9dac4f84b4f705e28a0 commit 48809ba74554b33b0250a9dac4f84b4f705e28a0 Author: Jacob Erlbeck Date: Thu Aug 28 13:20:39 2014 +0200 gbproxy: Copy uplink messages to SGSN 2 Some messages that are related to the BVC itself must be forwarded to the secondary SGSN, too. This patch implements this for BVC-RESET (BVCI != 0) and FLOW-CONTROL-BVC messages. The resulting acknowledgement messages from the secondary SGSN are silently dropped. The idea behind this is that the primary SGSN is responsible for setting up and maintaining the BVC whereas the secondary SGSN is rather passive and just has to accept it. Ticket: OW#1258 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0086bb8d3a2c23d9c23ecbd2e8cc95e2524aa56a commit 0086bb8d3a2c23d9c23ecbd2e8cc95e2524aa56a Author: Jacob Erlbeck Date: Wed Aug 27 12:51:07 2014 +0200 gbproxy: Use secondary SGSN if IMSI matches This patch modifies gbprox_process_bssgp_ul() to send the message to the secondary SGSN if the IMSI has matched and routing to the secondary SGSN is enabled. The destination for stored messages is modified accordingly. Ticket: OW#1261 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5b35d53fcbb29d0048bbde408add63cb9a56c89e commit 5b35d53fcbb29d0048bbde408add63cb9a56c89e Author: Jacob Erlbeck Date: Wed Aug 27 12:44:25 2014 +0200 gbproxy/test: Add test case for secondary SGSN This patch adds a case to test the establishment (and shutdown) of connection between 2 MS and 2 SGSN, where the assignment is based on each IMSI. Since BVC-RESET and FLOW-CONTROL-BVC will have to be sent to both SGSN, an ACK is simulated for both. New functions to generate FLOW-CONTROL-BVC(-ACK) messages are provided. It modifies dump_peers to add the string "IMSI matches" to a TLLI dump line if appropriate. Note that there is no real support to use a secondary SGSN in the gbproxy yet, but the test code reflects the expected behaviour when the feature is implemented. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=db96465cce031aca162ffad81033fa6d3443f150 commit db96465cce031aca162ffad81033fa6d3443f150 Author: Jacob Erlbeck Date: Tue Aug 26 14:47:15 2014 +0200 gbproxy: Support a secondary SGSN This patch refactors SGSN NSEI handling to support a secondary SGSN. It adds the following VTY commands: - secondary-sgsn nsei <0-65534> - no secondary-sgsn Sending messages to the secondary SGSN is not yet implemented, but received messages from such a SGSN would be forwarded to the BSS peers. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5ce228b002f906f8a076ebddfa72831eb95c2104 commit 5ce228b002f906f8a076ebddfa72831eb95c2104 Author: Jacob Erlbeck Date: Thu Sep 4 11:17:47 2014 +0200 gbproxy: Fix warnings This patch fixes the remaining 'unused' warnings. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/tests/mgcp/mgcp_transcoding_test.c | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)